Changeset 140622 in webkit
- Timestamp:
- Jan 23, 2013 5:54:13 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r140620 r140622 1 2013-01-23 Benjamin Poulain <bpoulain@apple.com> 2 3 RenderProgress does not repaint on value change 4 https://bugs.webkit.org/show_bug.cgi?id=106977 5 6 Reviewed by Joseph Pecoraro. 7 8 No test because the ouput depends on the code of RenderTheme, and 9 we use the platform theme for testing. 10 11 * rendering/RenderProgress.cpp: 12 (WebCore::RenderProgress::updateFromElement): 13 (WebCore::RenderProgress::updateAnimationState): 14 Previously, repaint() was only called on two occasions: 15 -On animationTimerFired(). 16 -In response to updateFromElement() if and only if the RenderTheme start/stop an 17 animation previously stopped/running. 18 19 When changing the value of HTMLProgressElement, no repaint was called until 20 the next timer fired for the animation. 21 This is a problem if: 22 -The animation of RenderTheme is slow. 23 -If there is no animation (the element is never updated in that case). 24 1 25 2013-01-23 Ian Vollick <vollick@chromium.org> 2 26 -
trunk/Source/WebCore/rendering/RenderProgress.cpp
r124754 r140622 57 57 58 58 updateAnimationState(); 59 repaint(); 59 60 RenderBlock::updateFromElement(); 60 61 } … … 92 93 return; 93 94 94 repaint();95 95 m_animating = animating; 96 96 if (m_animating) {
Note: See TracChangeset
for help on using the changeset viewer.