Changeset 140638 in webkit

Timestamp:

Jan 23, 2013 8:06:22 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Don't allocate rare data on every Element on removal
​https://bugs.webkit.org/show_bug.cgi?id=107756

Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-23
Reviewed by Eric Seidel.

We should not allocate an ElementRareData for every element
in Element::removedFrom. Previously calls to setIsInTopLayer
would unconditionally call ensureElementRareData(), and this was
called from Element::removedFrom meaning removing an element
made the entire subtree suddenly balloon to huge in size as each
one got an ElementRareData.

This is a regression from my patch on Bug 103912 where I removed a check
that avoided this allocation.

No new tests needed, covered by existing tests.

• dom/Element.cpp:

(WebCore::Element::setIsInTopLayer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-23  Elliott Sprehn  <esprehn@gmail.com>
+
+        Don't allocate rare data on every Element on removal
+        https://bugs.webkit.org/show_bug.cgi?id=107756
+
+        Reviewed by Eric Seidel.
+
+        We should not allocate an ElementRareData for every element
+        in Element::removedFrom. Previously calls to setIsInTopLayer
+        would unconditionally call ensureElementRareData(), and this was
+        called from Element::removedFrom meaning removing an element
+        made the entire subtree suddenly balloon to huge in size as each
+        one got an ElementRareData.
+
+        This is a regression from my patch on Bug 103912 where I removed a check
+        that avoided this allocation.
+
+        No new tests needed, covered by existing tests.
+
+        * dom/Element.cpp:
+        (WebCore::Element::setIsInTopLayer):
+
 2013-01-23  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -2402 +2402 @@
 void Element::setIsInTopLayer(bool inTopLayer)
 {
+    if (isInTopLayer() == inTopLayer)
+        return;
     ensureElementRareData()->setIsInTopLayer(inTopLayer);
     setNeedsStyleRecalc(SyntheticStyleChange);