Changeset 140659 in webkit

Timestamp:

Jan 24, 2013 12:23:16 AM (11 years ago)

Author:

morrita@google.com

Message:

There are a few of wrong removeAllChildren() call
​https://bugs.webkit.org/show_bug.cgi?id=107790

Reviewed by Ryosuke Niwa.

Source/WebCore:

removeAllChildren() is designed for trashing deleting children out.
It doesn't detach() children and could have possible leak.
This change replaces such removeAllChildren() usage with safer removeChildren().

No new tests. Covered by existing tests.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

• html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

• html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

Source/WebKit/qt:

• Api/qwebelement.cpp: Repalced removeAllChildren() with safer removeChildren()

(QWebElement::removeAllChildren):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (1 diff)
• WebCore/html/InputType.cpp (modified) (2 diffs)
• WebCore/html/ValidationMessage.cpp (modified) (1 diff)
• WebCore/html/parser/HTMLTreeBuilder.cpp (modified) (1 diff)
• WebKit/qt/Api/qwebelement.cpp (modified) (1 diff)
• WebKit/qt/ChangeLog (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  Hajime Morrita  <morrita@google.com>
+
+        There are a few of wrong removeAllChildren() call
+        https://bugs.webkit.org/show_bug.cgi?id=107790
+
+        Reviewed by Ryosuke Niwa.
+
+        removeAllChildren() is designed for trashing deleting children out.
+        It doesn't detach() children and could have possible leak.
+        This change replaces such removeAllChildren() usage with safer removeChildren().
+
+        No new tests. Covered by existing tests.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::parseAttribute):
+        * html/InputType.cpp:
+        (WebCore::InputType::destroyShadowSubtree):
+        * html/ValidationMessage.cpp:
+        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::processEndTag):
+
 2013-01-24  Dominic Mazzoni  <dmazzoni@google.com>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -753 +753 @@
             m_inputType->destroyShadowSubtree();
             m_inputType->createShadowSubtree();
-            attach();
+            if (!attached())
+                attach();
         } else {
             m_inputType->destroyShadowSubtree();

trunk/Source/WebCore/html/InputType.cpp

@@ -490 +490 @@
         return;
 
-    root->removeAllChildren();
+    root->removeChildren();
 
     // It's ok to clear contents of all other ShadowRoots because they must have
@@ -497 +497 @@
     while ((root = root->youngerShadowRoot())) {
 #if ENABLE(SHADOW_DOM)
-        root->removeAllChildren();
+        root->removeChildren();
         root->appendChild(HTMLShadowElement::create(shadowTag, element()->document()));
 #else

trunk/Source/WebCore/html/ValidationMessage.cpp

@@ -126 +126 @@
     ASSERT(m_messageHeading);
     ASSERT(m_messageBody);
-    m_messageHeading->removeAllChildren();
-    m_messageBody->removeAllChildren();
+    m_messageHeading->removeChildren();
+    m_messageBody->removeChildren();
     Vector<String> lines;
     m_message.split('\n', lines);

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -2153 +2153 @@
             m_tree.openElements()->pop();
             if (isParsingFragment() && !scriptingContentIsAllowed(m_fragmentContext.scriptingPermission()))
-                m_scriptToProcess->removeAllChildren();
+                m_scriptToProcess->removeChildren();
             setInsertionMode(m_originalInsertionMode);
 

trunk/Source/WebKit/qt/Api/qwebelement.cpp

@@ -1199 +1199 @@
         return;
 
-    m_element->removeAllChildren();
+    m_element->removeChildren();
 }
 

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2013-01-24  Hajime Morrita  <morrita@google.com>
+
+        There are a few of wrong removeAllChildren() call
+        https://bugs.webkit.org/show_bug.cgi?id=107790
+
+        Reviewed by Ryosuke Niwa.
+
+        * Api/qwebelement.cpp: Repalced removeAllChildren() with safer removeChildren()
+        (QWebElement::removeAllChildren):
+
 2013-01-23  Shinya Kawanaka  <shinyak@chromium.org>