Changeset 140691 in webkit


Ignore:
Timestamp:
Jan 24, 2013 9:39:18 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: expand more chunks in DTE
​https://bugs.webkit.org/show_bug.cgi?id=107698

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-24
Reviewed by Pavel Feldman.

Source/WebCore:

Mock DefaultTextEditor visible area as if it is slightly larger than real one and
do all chunk expandings and repaints based on this new area.

No new tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorChunkedPanel.prototype.findVisibleChunks):

LayoutTests:

Correct text expectation as we change amount of expanded chunks.

  • inspector/editor/text-editor-selection-expected.txt:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r140689 r140691  
     12013-01-24  Andrey Lushnikov  <lushnikov@chromium.org>
     2
     3        Web Inspector: expand more chunks in DTE
     4        https://bugs.webkit.org/show_bug.cgi?id=107698
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Correct text expectation as we change amount of expanded chunks.
     9
     10        * inspector/editor/text-editor-selection-expected.txt:
     11
    1122013-01-24  Ádám Kallai  <kadam@inf.u-szeged.hu>
    213

  • trunk/LayoutTests/inspector/editor/text-editor-selection-expected.txt

    r135606 r140691  
    33Chunk model
    44Chunk [0] 0:9 (expanded)
    5 Chunk [1] 9:18 (collapsed)
     5Chunk [1] 9:18 (expanded)
    66Chunk [2] 18:27 (collapsed)
    77Chunk [3] 27:34 (collapsed)

  • trunk/Source/WebCore/ChangeLog

    r140685 r140691  
     12013-01-24  Andrey Lushnikov  <lushnikov@chromium.org>
     2
     3        Web Inspector: expand more chunks in DTE
     4        https://bugs.webkit.org/show_bug.cgi?id=107698
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Mock DefaultTextEditor visible area as if it is slightly larger than real one and
     9        do all chunk expandings and repaints based on this new area.
     10
     11        No new tests: no change in behaviour.
     12
     13        * inspector/front-end/DefaultTextEditor.js:
     14        (WebInspector.TextEditorChunkedPanel.prototype.findVisibleChunks):
     15
    1162013-01-24  Victor Jaquez  <vjaquez@igalia.com>
    217

  • trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js

    r140556 r140691  
    895895    findVisibleChunks: function(visibleFrom, visibleTo)
    896896    {
     897        var span = (visibleTo - visibleFrom) * 0.5;
     898        visibleFrom = Math.max(visibleFrom - span, 0);
     899        visibleTo = visibleTo + span;
     900
    897901        var from = this._findFirstVisibleChunkNumber(visibleFrom);
    898902        for (var to = from + 1; to < this._textChunks.length; ++to) {
Note: See TracChangeset for help on using the changeset viewer.