Changeset 140709 in webkit

Timestamp:

Jan 24, 2013 12:40:23 PM (11 years ago)

Author:

mkwst@chromium.org

Message:

Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
​https://bugs.webkit.org/show_bug.cgi?id=107816

Reviewed by Pavel Feldman.

Source/WebCore:

'console.debug' is currently aliased to 'console.log'. Since we now
render debug-level messages differently to log messages, we should use
the proper message level for 'console.debug'.

• page/Console.cpp:

(WebCore::Console::debug):

Replace the alias to 'console.log' with message creation at
DebugMessageLevel.

LayoutTests:

• inspector/console/console-tests-expected.txt:
• inspector/extensions/extensions-console-expected.txt:

Rebaseline this test with the updated message level.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/console/console-tests-expected.txt (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-console-expected.txt (modified) (3 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/Console.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-24  Mike West  <mkwst@chromium.org>
+
+        Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
+        https://bugs.webkit.org/show_bug.cgi?id=107816
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/console/console-tests-expected.txt:
+        * inspector/extensions/extensions-console-expected.txt:
+            Rebaseline this test with the updated message level.
+
 2013-01-24  Dima Gorbik  <dgorbik@apple.com>
 

trunk/LayoutTests/inspector/console/console-tests-expected.txt

@@ -23 +23 @@
 
 log console-tests.html:9 console-message console-log-level
-debug console-tests.html:10 console-message console-log-level
+debug console-tests.html:10 console-message console-debug-level
 info console-tests.html:11 console-message console-log-level
 warn console-tests.html:12 console-message console-warning-level

trunk/LayoutTests/inspector/extensions/extensions-console-expected.txt

@@ -17 +17 @@
 RUNNING TEST: extension_testAddConsoleMessages
 log message extensions-console.html:46 console-message console-log-level
-debug message extensions-console.html:47 console-message console-log-level
+debug message extensions-console.html:47 console-message console-debug-level
 warning message extensions-console.html:48 console-message console-warning-level
 error message extensions-console.html:49 console-message console-error-level
@@ -36 +36 @@
     1 : {
         line : 47
-        severity : "log"
+        severity : "debug"
         text : "debug message"
         url : .../extensions-console.html
@@ -95 +95 @@
     0 : {
         line : 47
-        severity : "log"
+        severity : "debug"
         text : "debug message"
         url : .../extensions-console.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  Mike West  <mkwst@chromium.org>
+
+        Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
+        https://bugs.webkit.org/show_bug.cgi?id=107816
+
+        Reviewed by Pavel Feldman.
+
+        'console.debug' is currently aliased to 'console.log'. Since we now
+        render debug-level messages differently to log messages, we should use
+        the proper message level for 'console.debug'.
+
+        * page/Console.cpp:
+        (WebCore::Console::debug):
+            Replace the alias to 'console.log' with message creation at
+            DebugMessageLevel.
+
 2013-01-24  Dima Gorbik  <dgorbik@apple.com>
 

trunk/Source/WebCore/page/Console.cpp

@@ -234 +234 @@
 void Console::debug(ScriptState* state, PassRefPtr<ScriptArguments> arguments)
 {
-    // In Firebug, console.debug has the same behavior as console.log. So we'll do the same.
-    log(state, arguments);
+    internalAddMessage(page(), LogMessageType, DebugMessageLevel, state, arguments);
 }