Changeset 140732 in webkit

Timestamp:

Jan 24, 2013 3:14:42 PM (11 years ago)

Author:

jamesr@google.com

Message:

REGRESSION(140571): Crash in ScrollingCoordinator::mainThreadScrollingReasons during Frame::createView
​https://bugs.webkit.org/show_bug.cgi?id=107868

Reviewed by Beth Dakin.

When using fixed layout mode, it's possible to update the scrollbar state of the main FrameView before
it's set on the main frame, which can lead to calling in to ScrollingCoordinator to compute main thread
scrolling regions when m_page->mainFrame()->view() is 0. In this case, we don't have any main
thread scrolling reasons and should just return 0.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  James Robinson  <jamesr@chromium.org>
+
+        REGRESSION(140571): Crash in ScrollingCoordinator::mainThreadScrollingReasons during Frame::createView
+        https://bugs.webkit.org/show_bug.cgi?id=107868
+
+        Reviewed by Beth Dakin.
+
+        When using fixed layout mode, it's possible to update the scrollbar state of the main FrameView before
+        it's set on the main frame, which can lead to calling in to ScrollingCoordinator to compute main thread
+        scrolling regions when m_page->mainFrame()->view() is 0. In this case, we don't have any main
+        thread scrolling reasons and should just return 0.
+
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
+
 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -450 +450 @@
 {
     FrameView* frameView = m_page->mainFrame()->view();
+    if (!frameView)
+        return static_cast<MainThreadScrollingReasons>(0);
 
     MainThreadScrollingReasons mainThreadScrollingReasons = (MainThreadScrollingReasons)0;