Changeset 140733 in webkit


Ignore:
Timestamp:
Jan 24, 2013 3:17:22 PM (11 years ago)
Author:
mkwst@chromium.org
Message:

Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
https://bugs.webkit.org/show_bug.cgi?id=107817

Reviewed by Pavel Feldman.

The 'XHR finished loading:' message is currently sent at
LogMessageLevel. Upon reflection, the only messages that should be
sent at that level are messages the developer generates herself via
'console.*' calls. This message is better categorized as 'debug'.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

Change the message to DebugMessageLevel.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r140732 r140733  
     12013-01-24  Mike West  <mkwst@chromium.org>
     2
     3        Web Inspector: "XHR loaded!" messages should be DebugMessageLevel.
     4        https://bugs.webkit.org/show_bug.cgi?id=107817
     5
     6        Reviewed by Pavel Feldman.
     7
     8        The 'XHR finished loading:' message is currently sent at
     9        LogMessageLevel. Upon reflection, the only messages that should be
     10        sent at that level are messages the developer generates herself via
     11        'console.*' calls. This message is better categorized as 'debug'.
     12
     13        * inspector/InspectorConsoleAgent.cpp:
     14        (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
     15            Change the message to DebugMessageLevel.
     16
    1172013-01-24  James Robinson  <jamesr@chromium.org>
    218
  • trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp

    r138457 r140733  
    269269    if (m_frontend && m_state->getBoolean(ConsoleAgentState::monitoringXHR)) {
    270270        String message = "XHR finished loading: \"" + url + "\".";
    271         addMessageToConsole(NetworkMessageSource, LogMessageType, LogMessageLevel, message, sendURL, sendLineNumber, 0, requestIdentifier);
     271        addMessageToConsole(NetworkMessageSource, LogMessageType, DebugMessageLevel, message, sendURL, sendLineNumber, 0, requestIdentifier);
    272272    }
    273273
Note: See TracChangeset for help on using the changeset viewer.