Changeset 140743 in webkit


Ignore:
Timestamp:
Jan 24, 2013 3:54:58 PM (11 years ago)
Author:
andersca@apple.com
Message:

More StorageAreaProxy cleanup
https://bugs.webkit.org/show_bug.cgi?id=107870

Reviewed by Beth Dakin.

Remove some unnecessary 'WebCore::' qualifications,
and implement StorageNamespaceProxy::storageArea.

  • WebProcess/Storage/StorageAreaProxy.cpp:
  • WebProcess/Storage/StorageAreaProxy.h:
  • WebProcess/Storage/StorageNamespaceProxy.cpp:
Location:
trunk/Source/WebKit2
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r140730 r140743  
     12013-01-24  Anders Carlsson  <andersca@apple.com>
     2
     3        More StorageAreaProxy cleanup
     4        https://bugs.webkit.org/show_bug.cgi?id=107870
     5
     6        Reviewed by Beth Dakin.
     7
     8        Remove some unnecessary 'WebCore::' qualifications,
     9        and implement StorageNamespaceProxy::storageArea.
     10       
     11        * WebProcess/Storage/StorageAreaProxy.cpp:
     12        * WebProcess/Storage/StorageAreaProxy.h:
     13        * WebProcess/Storage/StorageNamespaceProxy.cpp:
     14
    1152013-01-24  Sam Weinig  <sam@webkit.org>
    216
  • trunk/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp

    r140723 r140743  
    2727#include "StorageAreaProxy.h"
    2828
     29#include <WebCore/SecurityOrigin.h>
     30
     31using namespace WebCore;
     32
    2933namespace WebKit {
    3034
    31 PassRefPtr<StorageAreaProxy> StorageAreaProxy::create()
     35PassRefPtr<StorageAreaProxy> StorageAreaProxy::create(StorageNamespaceProxy* storageNamespaceProxy, PassRefPtr<SecurityOrigin> securityOrigin)
    3236{
    33     return adoptRef(new StorageAreaProxy);
     37    return adoptRef(new StorageAreaProxy(storageNamespaceProxy, securityOrigin));
    3438}
    3539
    36 StorageAreaProxy::StorageAreaProxy()
     40StorageAreaProxy::StorageAreaProxy(StorageNamespaceProxy*, PassRefPtr<SecurityOrigin>)
    3741{
     42    // FIXME: Implement.
    3843}
    3944
     
    4247}
    4348
    44 unsigned StorageAreaProxy::length(WebCore::ExceptionCode&, WebCore::Frame* sourceFrame) const
     49unsigned StorageAreaProxy::length(ExceptionCode&, Frame* sourceFrame) const
    4550{
    4651    // FIXME: Implement this.
     
    4853}
    4954
    50 String StorageAreaProxy::key(unsigned index, WebCore::ExceptionCode&, WebCore::Frame* sourceFrame) const
     55String StorageAreaProxy::key(unsigned index, ExceptionCode&, Frame* sourceFrame) const
    5156{
    5257    // FIXME: Implement this.
     
    5560}
    5661
    57 String StorageAreaProxy::getItem(const String& key, WebCore::ExceptionCode&, WebCore::Frame* sourceFrame) const
     62String StorageAreaProxy::getItem(const String& key, ExceptionCode&, Frame* sourceFrame) const
    5863{
    5964    // FIXME: Implement this.
     
    6267}
    6368
    64 void StorageAreaProxy::setItem(const String& key, const String& value, WebCore::ExceptionCode&, WebCore::Frame* sourceFrame)
     69void StorageAreaProxy::setItem(const String& key, const String& value, ExceptionCode&, Frame* sourceFrame)
    6570{
    6671    // FIXME: Implement this.
     
    6873}
    6974
    70 void StorageAreaProxy::removeItem(const String& key, WebCore::ExceptionCode&, WebCore::Frame* sourceFrame)
     75void StorageAreaProxy::removeItem(const String& key, ExceptionCode&, Frame* sourceFrame)
    7176{
    7277    // FIXME: Implement this.
     
    7479}
    7580
    76 void StorageAreaProxy::clear(WebCore::ExceptionCode&, WebCore::Frame* sourceFrame)
     81void StorageAreaProxy::clear(ExceptionCode&, Frame* sourceFrame)
    7782{
    7883    // FIXME: Implement this.
     
    8085}
    8186
    82 bool StorageAreaProxy::contains(const String& key, WebCore::ExceptionCode&, WebCore::Frame* sourceFrame) const
     87bool StorageAreaProxy::contains(const String& key, ExceptionCode&, Frame* sourceFrame) const
    8388{
    8489    // FIXME: Implement this.
     
    8792}
    8893
    89 bool StorageAreaProxy::canAccessStorage(WebCore::Frame*) const
     94bool StorageAreaProxy::canAccessStorage(Frame*) const
    9095{
    9196    // FIXME: Implement this.
  • trunk/Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h

    r140723 r140743  
    3131namespace WebKit {
    3232
     33class StorageNamespaceProxy;
     34
    3335class StorageAreaProxy : public WebCore::StorageArea {
    3436public:
    35     static PassRefPtr<StorageAreaProxy> create();
     37    static PassRefPtr<StorageAreaProxy> create(StorageNamespaceProxy*, PassRefPtr<WebCore::SecurityOrigin>);
    3638    virtual ~StorageAreaProxy();
    3739
    3840private:
    39     StorageAreaProxy();
     41    StorageAreaProxy(StorageNamespaceProxy*, PassRefPtr<WebCore::SecurityOrigin>);
    4042
    4143    // WebCore::StorageArea.
  • trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp

    r140712 r140743  
    2727#include "StorageNamespaceProxy.h"
    2828
     29#include "StorageAreaProxy.h"
     30#include <WebCore/SecurityOrigin.h>
     31
    2932using namespace WebCore;
    3033
     
    4447}
    4548
    46 PassRefPtr<WebCore::StorageArea> StorageNamespaceProxy::storageArea(PassRefPtr<WebCore::SecurityOrigin>)
     49PassRefPtr<StorageArea> StorageNamespaceProxy::storageArea(PassRefPtr<SecurityOrigin> securityOrigin)
    4750{
    48     // FIXME: Implement this.
    49     ASSERT_NOT_REACHED();
    50     return nullptr;
     51    return StorageAreaProxy::create(this, securityOrigin);
    5152}
    5253
    53 PassRefPtr<WebCore::StorageNamespace> StorageNamespaceProxy::copy()
     54PassRefPtr<StorageNamespace> StorageNamespaceProxy::copy()
    5455{
    5556    // FIXME: Implement this.
     
    6465}
    6566
    66 void StorageNamespaceProxy::clearOriginForDeletion(WebCore::SecurityOrigin*)
     67void StorageNamespaceProxy::clearOriginForDeletion(SecurityOrigin*)
    6768{
    6869    // FIXME: Implement this.
Note: See TracChangeset for help on using the changeset viewer.