Changeset 140786 in webkit

Timestamp:

Jan 24, 2013 11:00:11 PM (11 years ago)

Author:

abarth@webkit.org

Message:

HTTP 500 error between QueueStatusServer and bot(s)
​https://bugs.webkit.org/show_bug.cgi?id=107184

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-24
Reviewed by Adam Barth.

Removed the use of memcache which was the source of the exception.

• QueueStatusServer/handlers/updatestatus.py:

(UpdateStatus.post):

• QueueStatusServer/model/attachment.py:

(Attachment):
(Attachment.summary):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/handlers/updatestatus.py (modified) (1 diff)
• QueueStatusServer/model/attachment.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-01-24  Alan Cutter  <alancutter@chromium.org>
+
+        HTTP 500 error between QueueStatusServer and bot(s)
+        https://bugs.webkit.org/show_bug.cgi?id=107184
+
+        Reviewed by Adam Barth.
+
+        Removed the use of memcache which was the source of the exception.
+
+        * QueueStatusServer/handlers/updatestatus.py:
+        (UpdateStatus.post):
+        * QueueStatusServer/model/attachment.py:
+        (Attachment):
+        (Attachment.summary):
+
 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/QueueStatusServer/handlers/updatestatus.py

@@ -68 +68 @@
         if queue_status.active_patch_id:
             RecordPatchEvent.updated(queue_status.active_patch_id, queue_status.queue_name, queue_status.bot_id)
-        Attachment.dirty(queue_status.active_patch_id)
         self.response.out.write(queue_status.key().id())

trunk/Tools/QueueStatusServer/model/attachment.py

@@ -29 +29 @@
 import re
 
-from google.appengine.api import memcache
-
 from model.queues import Queue
 from model.queuestatus import QueueStatus
@@ -37 +35 @@
 
 class Attachment(object):
-    @classmethod
-    def dirty(cls, attachment_id):
-        memcache.delete(str(attachment_id), namespace="attachment-summary")
-
     @classmethod
     def recent(cls, limit=1):
@@ -67 +61 @@
         if self._summary:
             return self._summary
-        self._summary = memcache.get(str(self.id), namespace="attachment-summary")
-        if self._summary:
-            return self._summary
         self._summary = self._fetch_summary()
-        memcache.set(str(self.id), self._summary, namespace="attachment-summary")
         return self._summary