Changeset 140788 in webkit

Timestamp:

Jan 24, 2013 11:25:41 PM (11 years ago)

Author:

tkent@chromium.org

Message:

INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove unused DateTimeHourFieldElement::valueAsInteger
​https://bugs.webkit.org/show_bug.cgi?id=107915

Reviewed by Kentaro Hara.

DateTimeHourFieldElement::valueAsInteger is never called. Remove it and
make valueAsInteger non-public.

No new tests. This shouldn't change any behavior.

• html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Make valueAsInteger protected.

• html/shadow/DateTimeFieldElements.cpp:

Remove DateTimeHourFieldElement::valueAsInteger.
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState):
Remove unnecessary DateTimeNumericFieldElement:: prefix.

• html/shadow/DateTimeFieldElements.h:

(DateTimeHourFieldElement): Remove valueAsInteger.

• html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement):
Make valueAsInteger FINAL.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/shadow/DateTimeFieldElement.h (modified) (2 diffs)
• html/shadow/DateTimeFieldElements.cpp (modified) (2 diffs)
• html/shadow/DateTimeFieldElements.h (modified) (1 diff)
• html/shadow/DateTimeNumericFieldElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  Kent Tamura  <tkent@chromium.org>
+
+        INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove unused DateTimeHourFieldElement::valueAsInteger
+        https://bugs.webkit.org/show_bug.cgi?id=107915
+
+        Reviewed by Kentaro Hara.
+
+        DateTimeHourFieldElement::valueAsInteger is never called. Remove it and
+        make valueAsInteger non-public.
+
+        No new tests. This shouldn't change any behavior.
+
+        * html/shadow/DateTimeFieldElement.h:
+        (DateTimeFieldElement): Make valueAsInteger protected.
+        * html/shadow/DateTimeFieldElements.cpp:
+        Remove DateTimeHourFieldElement::valueAsInteger.
+        (WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState):
+        Remove unnecessary DateTimeNumericFieldElement:: prefix.
+        * html/shadow/DateTimeFieldElements.h:
+        (DateTimeHourFieldElement): Remove valueAsInteger.
+        * html/shadow/DateTimeNumericFieldElement.h:
+        (DateTimeNumericFieldElement):
+        Make valueAsInteger FINAL.
+
 2013-01-24  Hajime Morrita  <morrita@google.com>
 

trunk/Source/WebCore/html/shadow/DateTimeFieldElement.h

@@ -75 +75 @@
     virtual void stepUp() = 0;
     virtual String value() const = 0;
-    virtual int valueAsInteger() const = 0;
     virtual String visibleValue() const = 0;
 
@@ -90 +89 @@
     virtual int minimum() const = 0;
     void updateVisibleValue(EventBehavior);
+    virtual int valueAsInteger() const = 0;
 
 private:

trunk/Source/WebCore/html/shadow/DateTimeFieldElements.cpp

@@ -140 +140 @@
     }
 
-    const int value = DateTimeNumericFieldElement::valueAsInteger();
+    const int value = valueAsInteger();
 
     switch (maximum()) {
@@ -216 +216 @@
 }
 
-int DateTimeHourFieldElement::valueAsInteger() const
-{
-    return hasValue() ? DateTimeNumericFieldElement::valueAsInteger() % m_alignment : -1;
-}
-
 // ----------------------------
 

trunk/Source/WebCore/html/shadow/DateTimeFieldElements.h

@@ -86 +86 @@
     virtual void setValueAsDateTimeFieldsState(const DateTimeFieldsState&) OVERRIDE FINAL;
     virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) OVERRIDE FINAL;
-    virtual int valueAsInteger() const OVERRIDE FINAL;
 
     const int m_alignment;

trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.h

@@ -72 +72 @@
     virtual void setEmptyValue(EventBehavior = DispatchNoEvent) OVERRIDE FINAL;
     virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) OVERRIDE;
-    virtual int valueAsInteger() const OVERRIDE;
+    virtual int valueAsInteger() const OVERRIDE FINAL;
     virtual String visibleValue() const OVERRIDE FINAL;