Changeset 140794 in webkit

Timestamp:

Jan 25, 2013 12:23:58 AM (11 years ago)

Author:

dmazzoni@google.com

Message:

REGRESSION (r140658): Multiple accessibility failures on GTK
​https://bugs.webkit.org/show_bug.cgi?id=107832

Reviewed by Chris Fleizach.

Source/WebCore:

In the ATK accessibility implementation, attachWrapper
might create a different object depending on the role of
the WebCore AccessibilityObject, whereas on other platforms
attachWrapper doesn't care. Calling init before attachWrapper
solves the problem.

Re-enables 7 skipped tests.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

LayoutTests:

Re-enable accessibility tests that were skipped when they started
failing.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AXObjectCache.cpp (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-25  Dominic Mazzoni  <dmazzoni@google.com>
+
+        REGRESSION (r140658): Multiple accessibility failures on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=107832
+
+        Reviewed by Chris Fleizach.
+
+        Re-enable accessibility tests that were skipped when they started
+        failing.
+
+        * platform/gtk/TestExpectations:
+
 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1407 +1407 @@
 webkit.org/b/106563 fast/css/image-orientation/image-orientation.html [ Failure ]
 
-webkit.org/b/107832 accessibility/aria-slider-value.html [ Failure ]
-webkit.org/b/107832 accessibility/aria-tables.html [ Failure ]
-webkit.org/b/107832 accessibility/document-attributes.html [ Failure ]
-webkit.org/b/107832 accessibility/language-attribute.html [ Failure ]
-webkit.org/b/107832 accessibility/spinbutton-value.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/aria-slider-required-attributes.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/entry-and-password.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html [ Failure ]
-webkit.org/b/107832 platform/gtk/accessibility/table-hierarchy.html [ Failure ]
-
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Tests failing

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-25  Dominic Mazzoni  <dmazzoni@google.com>
+
+        REGRESSION (r140658): Multiple accessibility failures on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=107832
+
+        Reviewed by Chris Fleizach.
+
+        In the ATK accessibility implementation, attachWrapper
+        might create a different object depending on the role of
+        the WebCore AccessibilityObject, whereas on other platforms
+        attachWrapper doesn't care. Calling init before attachWrapper
+        solves the problem.
+
+        Re-enables 7 skipped tests.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::getOrCreate):
+
 2013-01-24  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -314 +314 @@
     m_widgetObjectMapping.set(widget, newObj->axObjectID());
     m_objects.set(newObj->axObjectID(), newObj);    
+    newObj->init();
     attachWrapper(newObj.get());
-    newObj->init();
     return newObj.get();
 }
@@ -349 +349 @@
     m_nodeObjectMapping.set(node, newObj->axObjectID());
     m_objects.set(newObj->axObjectID(), newObj);
+    newObj->init();
     attachWrapper(newObj.get());
-
-    newObj->init();
     newObj->setCachedIsIgnoredValue(newObj->accessibilityIsIgnored());
 
@@ -374 +373 @@
     m_renderObjectMapping.set(renderer, newObj->axObjectID());
     m_objects.set(newObj->axObjectID(), newObj);
+    newObj->init();
     attachWrapper(newObj.get());
-
-    newObj->init();
     newObj->setCachedIsIgnoredValue(newObj->accessibilityIsIgnored());
 
@@ -443 +441 @@
 
     m_objects.set(obj->axObjectID(), obj);    
+    obj->init();
     attachWrapper(obj.get());
-    obj->init();
     return obj.get();
 }