Changeset 140800 in webkit

Timestamp:

Jan 25, 2013 1:35:51 AM (11 years ago)

Author:

hans@chromium.org

Message:

Disable Clang's -Wreturn-type-c-linkage for Source/WebCore/bindings/v8/
​https://bugs.webkit.org/show_bug.cgi?id=107845

Reviewed by Adam Barth.

A recent version of Clang started warning about code in
Source/WebCore/bindings/v8/npruntime.cpp.

In this case it is warning about an 'extern "c"' function returning a
non-POD type. But because the function has internal linkage, the
warning doesn't really apply.

This change suppresses the warning in the meantime.

Tested by building with Clang r172454.

• WebCore.gyp/WebCore.gyp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gyp/WebCore.gyp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-24  Hans Wennborg  <hans@chromium.org>
+
+        Disable Clang's -Wreturn-type-c-linkage for Source/WebCore/bindings/v8/
+        https://bugs.webkit.org/show_bug.cgi?id=107845
+
+        Reviewed by Adam Barth.
+
+        A recent version of Clang started warning about code in
+        Source/WebCore/bindings/v8/npruntime.cpp.
+
+        In this case it is warning about an 'extern "c"' function returning a
+        non-POD type. But because the function has internal linkage, the
+        warning doesn't really apply.
+
+        This change suppresses the warning in the meantime.
+
+        Tested by building with Clang r172454.
+
+        * WebCore.gyp/WebCore.gyp:
+
 2013-01-25  Eberhard Graether  <egraether@google.com>
 

trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

@@ -2158 +2158 @@
           'sources/': [['exclude', 'Mac\\.(cpp|mm?)$']]
         }],
+        ['clang==1', {
+          # FIXME: Remove once this warning has been tweaked in Clang.
+          'cflags': [
+            '-Wno-return-type-c-linkage',
+          ],
+          'xcode_settings': {
+            'WARNING_CFLAGS': [
+              '-Wno-return-type-c-linkage',
+            ],
+          }
+        }],
       ],
     },