Changeset 140813 in webkit

Timestamp:

Jan 25, 2013 4:36:03 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Add explanation for Console object expansion behaviour
​https://bugs.webkit.org/show_bug.cgi?id=107793

Patch by Sergey Ryazanov <​serya@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

• English.lproj/localizedStrings.js:
• inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):

• inspector/front-end/inspector.css:

(.object-info-state-note):
(.object-info-state-note::before):
(.object-info-state-note:hover):
(.section.expanded .object-info-state-note):
(.section.expanded .properties, .event-bar.expanded .event-properties):
(.pane.expanded .properties, .event-bar .event-properties):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (1 diff)
• inspector/front-end/ConsoleMessage.js (modified) (1 diff)
• inspector/front-end/inspector.css (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-25  Sergey Ryazanov  <serya@chromium.org>
+
+        Web Inspector: Add explanation for Console object expansion behaviour
+        https://bugs.webkit.org/show_bug.cgi?id=107793
+
+        Reviewed by Pavel Feldman.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/ConsoleMessage.js:
+        (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArrayOrObject):
+        * inspector/front-end/inspector.css:
+        (.object-info-state-note):
+        (.object-info-state-note::before):
+        (.object-info-state-note:hover):
+        (.section.expanded .object-info-state-note):
+        (.section.expanded .properties, .event-bar.expanded .event-properties):
+        (.pane.expanded .properties, .event-bar .event-properties):
+
 2013-01-25  Claudio Saavedra  <csaavedra@igalia.com>
 

trunk/Source/WebCore/English.lproj/localizedStrings.js

@@ -848 +848 @@
 localizedStrings["Mappings"] = "Mappings";
 localizedStrings["Add"] = "Add";
+localizedStrings["Object state below is captured upon first expansion"] = "Object state below is captured upon first expansion";

trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js

@@ -305 +305 @@
         section.enableContextMenu();
         elem.appendChild(section.element);
+
+        var note = section.titleElement.createChild("span", "object-info-state-note");
+        note.title = WebInspector.UIString("Object state below is captured upon first expansion");
     },
 

trunk/Source/WebCore/inspector/front-end/inspector.css

@@ -1213 +1213 @@
 }
 
+.object-info-state-note {
+    display: none;
+    width: 12px;
+    height: 12px;
+    background-color: rgb(179, 203, 247);
+    color: white;
+    text-align: center;
+    border-radius: 5px;
+    line-height: 13px;
+    margin: 0 8px;
+}
+
+.object-info-state-note::before {
+    content: "i";
+}
+
+.object-info-state-note:hover {
+    background-color: rgb(52, 115, 231);
+}
+
+.section.expanded .object-info-state-note {
+    display: inline-block;
+}
+
 .error-message {
     color: red;
@@ -1535 +1559 @@
 .section.expanded .properties, .event-bar.expanded .event-properties {
     display: block;
+}
+
+.pane.expanded .properties, .event-bar .event-properties {
     padding-left: 16px;
 }