Changeset 140814 in webkit

Timestamp:

Jan 25, 2013 4:57:55 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: [Network] Use DataGrid column alignment instead of custom styling.
​https://bugs.webkit.org/show_bug.cgi?id=107935

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-25
Reviewed by Pavel Feldman.

On Network Panel column alignment is specified both in
column descriptors and in CSS stylesheet.

Only one alignment specifier should last.

• inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.createTD): Extracted common code.
(WebInspector.DataGridNode.prototype.createCell): Use "createTD".

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._createDivInTD): Ditto.

• inspector/front-end/networkLogView.css: Remove exheberant rules.
• inspector/front-end/networkPanel.css: Fix whitespaces.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DataGrid.js (modified) (2 diffs)
• inspector/front-end/NetworkPanel.js (modified) (1 diff)
• inspector/front-end/networkLogView.css (modified) (1 diff)
• inspector/front-end/networkPanel.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-25  Eugene Klyuchnikov  <eustas@chromium.org>
+
+        Web Inspector: [Network] Use DataGrid column alignment instead of custom styling.
+        https://bugs.webkit.org/show_bug.cgi?id=107935
+
+        Reviewed by Pavel Feldman.
+
+        On Network Panel column alignment is specified both in
+        column descriptors and in CSS stylesheet.
+
+        Only one alignment specifier should last.
+
+        * inspector/front-end/DataGrid.js:
+        (WebInspector.DataGridNode.prototype.createTD): Extracted common code.
+        (WebInspector.DataGridNode.prototype.createCell): Use "createTD". 
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkDataGridNode.prototype._createDivInTD): Ditto.
+        * inspector/front-end/networkLogView.css: Remove exheberant rules.
+        * inspector/front-end/networkPanel.css: Fix whitespaces.
+
 2013-01-25  Sergey Ryazanov  <serya@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DataGrid.js

@@ -1259 +1259 @@
     },
 
-    createCell: function(columnIdentifier)
+    /**
+     * @param {string} columnIdentifier
+     * @return {!Element}
+     */
+    createTD: function(columnIdentifier)
     {
         var cell = document.createElement("td");
@@ -1268 +1272 @@
         if (alignment)
             cell.addStyleClass(alignment);
+
+        return cell;
+    },
+
+    createCell: function(columnIdentifier)
+    {
+        var cell = this.createTD(columnIdentifier);
 
         var data = this.data[columnIdentifier];

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -2016 +2016 @@
     _createDivInTD: function(columnIdentifier)
     {
-        var td = document.createElement("td");
-        td.className = columnIdentifier + "-column";
-        var div = document.createElement("div");
-        td.appendChild(div);
+        var td = this.createTD(columnIdentifier);
+        var div = td.createChild("div");
         this._element.appendChild(td);
         return div;

trunk/Source/WebCore/inspector/front-end/networkLogView.css

@@ -85 +85 @@
 #network-container:not(.brief-mode) .network-log-grid.data-grid td.name-column:hover {
     text-decoration: underline;
-}
-
-.network-log-grid.data-grid td.size-column,
-.network-log-grid.data-grid td.time-column {
-    text-align: right;
 }
 

trunk/Source/WebCore/inspector/front-end/networkPanel.css

@@ -50 +50 @@
 }
 
-#network-views.small #network-close-button  {
+#network-views.small #network-close-button {
     top: 4px;
 }