Changeset 140817 in webkit

Timestamp:

Jan 25, 2013 5:07:19 AM (11 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
​https://bugs.webkit.org/show_bug.cgi?id=107936

Reviewed by Yury Semikhatsky.

Source/WebCore:

Restore the original CSS property value before editing.

Test: inspector/styles/edit-value-with-trimmed-url.html

• inspector/front-end/StylesSidebarPane.js:

LayoutTests:

• inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
• inspector/styles/edit-value-with-trimmed-url.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/styles/edit-value-with-trimmed-url-expected.txt (added)
• LayoutTests/inspector/styles/edit-value-with-trimmed-url.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/StylesSidebarPane.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-25  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
+        https://bugs.webkit.org/show_bug.cgi?id=107936
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
+        * inspector/styles/edit-value-with-trimmed-url.html: Added.
+
 2013-01-25  Keishi Hattori  <keishi@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-25  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
+        https://bugs.webkit.org/show_bug.cgi?id=107936
+
+        Reviewed by Yury Semikhatsky.
+
+        Restore the original CSS property value before editing.
+
+        Test: inspector/styles/edit-value-with-trimmed-url.html
+
+        * inspector/front-end/StylesSidebarPane.js:
+
 2013-01-25  Eugene Klyuchnikov  <eustas@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js

@@ -2076 +2076 @@
 
         var isEditingName = selectElement === this.nameElement;
-        if (!isEditingName && selectElement !== this.valueElement) {
-            // Double-click in the LI - start editing value.
-            isEditingName = false;
-            selectElement = this.valueElement;
+        if (!isEditingName) {
+            if (selectElement !== this.valueElement) {
+                // Click in the LI - start editing value.
+                isEditingName = false;
+                selectElement = this.valueElement;
+            }
+
+            this.valueElement.textContent = this.value;
         }