Changeset 140830 in webkit
- Timestamp:
- Jan 25, 2013 8:31:08 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r140828 r140830 1 2013-01-25 Mike West <mkwst@chromium.org> 2 3 Web Inspector: Cleanup console.* API MessageSource/Levels. 4 https://bugs.webkit.org/show_bug.cgi?id=107946 5 6 Reviewed by Pavel Feldman. 7 8 * inspector/console/console-tests-expected.txt: 9 1 10 2013-01-25 Andrey Lushnikov <lushnikov@chromium.org> 2 11 -
trunk/LayoutTests/inspector/console/console-tests-expected.txt
r140709 r140830 28 28 error console-tests.html:13 console-message console-error-level 29 29 5repeated console-tests.html:15 console-message console-log-level repeated-message 30 count: 1 console-tests.html:17 console-message console- log-level31 count: 2 console-tests.html:17 console-message console- log-level30 count: 1 console-tests.html:17 console-message console-debug-level 31 count: 2 console-tests.html:17 console-message console-debug-level 32 32 group console-tests.html:18 console-message console-log-level console-group-title 33 33 console-message console-log-level -
trunk/Source/WebCore/ChangeLog
r140828 r140830 1 2013-01-25 Mike West <mkwst@chromium.org> 2 3 Web Inspector: Cleanup console.* API MessageSource/Levels. 4 https://bugs.webkit.org/show_bug.cgi?id=107946 5 6 Reviewed by Pavel Feldman. 7 8 This patch does some light cleanup on sources and levels of console.* 9 messages as part of a broader effort to offer better filtering options 10 in the console. Specifically: 11 12 - console.timeEnd and console.count now come from 13 ConsoleAPIMessageSource. 14 - console.count is now DebugMessageLevel (to match console.timeEnd). 15 - console.profile and console.profileEnd now comr from 16 ConsoleAPIMessageSource, and are DebugMessageLevel. 17 18 * inspector/InspectorConsoleAgent.cpp: 19 (WebCore::InspectorConsoleAgent::stopTiming): 20 (WebCore::InspectorConsoleAgent::count): 21 * inspector/InspectorProfilerAgent.cpp: 22 (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): 23 (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): 24 1 25 2013-01-25 Andrey Lushnikov <lushnikov@chromium.org> 2 26 -
trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
r140733 r140830 227 227 String message = title + String::format(": %.3fms", elapsed * 1000); 228 228 const ScriptCallFrame& lastCaller = callStack->at(0); 229 addMessageToConsole( JSMessageSource, TimingMessageType, DebugMessageLevel, message, lastCaller.sourceURL(), lastCaller.lineNumber());229 addMessageToConsole(ConsoleAPIMessageSource, TimingMessageType, DebugMessageLevel, message, lastCaller.sourceURL(), lastCaller.lineNumber()); 230 230 } 231 231 … … 252 252 253 253 String message = title + ": " + String::number(count); 254 addMessageToConsole( JSMessageSource, LogMessageType, LogMessageLevel, message, callStack);254 addMessageToConsole(ConsoleAPIMessageSource, LogMessageType, DebugMessageLevel, message, callStack); 255 255 } 256 256 -
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp
r139998 r140830 167 167 String title = profile->title(); 168 168 String message = makeString("Profile \"webkit-profile://", CPUProfileType, '/', encodeWithURLEscapeSequences(title), '#', String::number(profile->uid()), "\" finished."); 169 m_consoleAgent->addMessageToConsole( JSMessageSource, LogMessageType, LogMessageLevel, message, sourceURL, lineNumber);169 m_consoleAgent->addMessageToConsole(ConsoleAPIMessageSource, LogMessageType, DebugMessageLevel, message, sourceURL, lineNumber); 170 170 } 171 171 … … 175 175 return; 176 176 String message = makeString("Profile \"webkit-profile://", CPUProfileType, '/', encodeWithURLEscapeSequences(title), "#0\" started."); 177 m_consoleAgent->addMessageToConsole( JSMessageSource, LogMessageType, LogMessageLevel, message, sourceURL, lineNumber);177 m_consoleAgent->addMessageToConsole(ConsoleAPIMessageSource, LogMessageType, DebugMessageLevel, message, sourceURL, lineNumber); 178 178 } 179 179
Note: See TracChangeset
for help on using the changeset viewer.