Changeset 140867 in webkit

Timestamp:

Jan 25, 2013 2:35:29 PM (11 years ago)

Author:

tonyg@chromium.org

Message:

Fix an ASSERT in BackgroundHTMLParser::appendPartial
​https://bugs.webkit.org/show_bug.cgi?id=107983

Reviewed by Eric Seidel.

The complier may create a temporary for the isolatedCopy of the source string. This could cause the refCount of the
StringImpl to be greater than one when appendPartial is invoked on the background thread.
This patch ensures the temporary is gone by that time which fixes the ASSERT in numerous layout tests.

No new tests because covered by existing tests.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::append):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLDocumentParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-25  Tony Gentilcore  <tonyg@chromium.org>
+
+        Fix an ASSERT in BackgroundHTMLParser::appendPartial
+        https://bugs.webkit.org/show_bug.cgi?id=107983
+
+        Reviewed by Eric Seidel.
+
+        The complier may create a temporary for the isolatedCopy of the source string. This could cause the refCount of the
+        StringImpl to be greater than one when appendPartial is invoked on the background thread.
+        This patch ensures the temporary is gone by that time which fixes the ASSERT in numerous layout tests.
+
+        No new tests because covered by existing tests.
+
+        * html/parser/HTMLDocumentParser.cpp:
+        (WebCore::HTMLDocumentParser::append):
+
 2013-01-25  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp

@@ -499 +499 @@
 
         ParserIdentifier identifier = ParserMap::identifierForParser(this);
-        HTMLParserThread::shared()->postTask(bind(&BackgroundHTMLParser::appendPartial, identifier, source.toString().isolatedCopy()));
+        const Closure& appendPartial = bind(&BackgroundHTMLParser::appendPartial, identifier, source.toString().isolatedCopy());
+        HTMLParserThread::shared()->postTask(appendPartial);
         return;
     }