Changeset 140955 in webkit

Timestamp:

Jan 28, 2013 1:39:13 AM (11 years ago)

Author:

keishi@webkit.org

Message:

[REGRESSION] Calendar Picker focus ring is gone
​https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

The focus ring wasn't visible because -webkit-focus-ring-color value
only works for outline property in strict mode. Using fixed color
instead.

No new tests. Can't reproduce in layout test because mock popup writes a
script tag in front of the doctype.

• Resources/pagepopups/chromium/calendarPickerChromium.css:

(.days-area-container:focus):

• Resources/pagepopups/chromium/pickerCommonChromium.css:

(:enabled:focus:-webkit-any(button, input[type='button'])):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Resources/pagepopups/chromium/calendarPickerChromium.css (modified) (1 diff)
• Resources/pagepopups/chromium/pickerCommonChromium.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-28  Keishi Hattori  <keishi@webkit.org>
+
+        [REGRESSION] Calendar Picker focus ring is gone
+        https://bugs.webkit.org/show_bug.cgi?id=108055
+
+        Reviewed by Kent Tamura.
+
+        The focus ring wasn't visible because -webkit-focus-ring-color value
+        only works for outline property in strict mode. Using fixed color
+        instead.
+
+        No new tests. Can't reproduce in layout test because mock popup writes a
+        script tag in front of the doctype.
+
+        * Resources/pagepopups/chromium/calendarPickerChromium.css:
+        (.days-area-container:focus):
+        * Resources/pagepopups/chromium/pickerCommonChromium.css:
+        (:enabled:focus:-webkit-any(button, input[type='button'])):
+
 2013-01-25  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/Resources/pagepopups/chromium/calendarPickerChromium.css

@@ -10 +10 @@
     /* We use border color because it follows the border radius (unlike outline).
     * This is particularly noticeable on mac. */
-    border-color: -webkit-focus-ring-color;
+    border-color: rgb(77, 144, 254);
     outline: none;
 }

trunk/Source/WebCore/Resources/pagepopups/chromium/pickerCommonChromium.css

@@ -42 +42 @@
     /* We use border color because it follows the border radius (unlike outline).
     * This is particularly noticeable on mac. */
-    border-color: -webkit-focus-ring-color;
+    border-color: rgb(77, 144, 254);
     outline: none;
 }