Changeset 140974 in webkit


Ignore:
Timestamp:
Jan 28, 2013 9:05:59 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
​https://bugs.webkit.org/show_bug.cgi?id=107650

Source/WebCore:

Patch by James Craig <​james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).

Test: platform/mac/accessibility/definition-list-term.html:
Test: accessibility/lists.html

  • English.lproj/Localizable.strings:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isDescriptionList):

  • accessibility/AccessibilityList.h:

(AccessibilityList):

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListTermText):
(WebCore):
(WebCore::AXDescriptionListDetailText):

  • platform/LocalizedStrings.h:

(WebCore):

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListDetailText):
(WebCore):
(WebCore::AXDescriptionListTermText):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::AXDefinitionText):
(WebCore::AXDescriptionListTermText):
(WebCore):
(WebCore::AXDescriptionListDetailText):

Source/WebKit/chromium:

Patch by James Craig <​james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
  • src/LocalizedStrings.cpp:

(WebCore::AXDefinitionText):
(WebCore):
(WebCore::AXDescriptionListTermText):
(WebCore::AXDescriptionListDetailText):

Tools:

Patch by James Craig <​james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:

(createDescriptionList):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Patch by James Craig <​james@cookiecrook.com> on 2013-01-28
Reviewed by Chris Fleizach.

Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
Removed gtk expectation as the expectation has changed: platform/gtk/accessibility/lists-expected.txt

  • accessibility/lists.html:
  • platform/gtk/accessibility/lists-expected.txt: Removed.
  • platform/mac/accessibility/definition-list-term-expected.txt:
  • platform/mac/accessibility/definition-list-term.html:
  • platform/mac/accessibility/lists-expected.txt:
Location:
trunk
Files:
1 deleted
27 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r140972 r140974  
     12013-01-28  James Craig  <james@cookiecrook.com>
     2
     3        HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
     4        https://bugs.webkit.org/show_bug.cgi?id=107650
     5
     6        Reviewed by Chris Fleizach.
     7       
     8        Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
     9        Removed gtk expectation as the expectation has changed: platform/gtk/accessibility/lists-expected.txt
     10
     11        * accessibility/lists.html:
     12        * platform/gtk/accessibility/lists-expected.txt: Removed.
     13        * platform/mac/accessibility/definition-list-term-expected.txt:
     14        * platform/mac/accessibility/definition-list-term.html:
     15        * platform/mac/accessibility/lists-expected.txt:
     16
    1172013-01-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
    218

  • trunk/LayoutTests/accessibility/lists.html

    r120111 r140974  
     1<!DOCTYPE html>
    12<html>
    23<script>

  • trunk/LayoutTests/platform/mac/accessibility/definition-list-term-expected.txt

    r51670 r140974  
    1111PASS obj.childAtIndex(0).roleDescription is "AXRoleDescription: term"
    1212PASS obj.childAtIndex(1).role is 'AXRole: AXGroup'
    13 PASS obj.childAtIndex(1).subrole is "AXSubrole: AXDefinition"
    14 PASS obj.childAtIndex(1).roleDescription is "AXRoleDescription: definition"
     13PASS obj.childAtIndex(1).subrole is "AXSubrole: AXDescription"
     14PASS obj.childAtIndex(1).roleDescription is "AXRoleDescription: description"
    1515PASS obj.childAtIndex(1).role is 'AXRole: AXGroup'
    16 PASS obj.childAtIndex(1).subrole is "AXSubrole: AXDefinition"
    17 PASS obj.childAtIndex(1).roleDescription is "AXRoleDescription: definition"
     16PASS obj.childAtIndex(1).subrole is "AXSubrole: AXDescription"
     17PASS obj.childAtIndex(1).roleDescription is "AXRoleDescription: description"
    1818PASS successfullyParsed is true
    1919

  • trunk/LayoutTests/platform/mac/accessibility/definition-list-term.html

    r99258 r140974  
    2929
    3030          shouldBe("obj.childAtIndex(1).role", "'AXRole: AXGroup'");
    31           shouldBe("obj.childAtIndex(1).subrole", '"AXSubrole: AXDefinition"');
    32           shouldBe("obj.childAtIndex(1).roleDescription", '"AXRoleDescription: definition"');
     31          shouldBe("obj.childAtIndex(1).subrole", '"AXSubrole: AXDescription"');
     32          shouldBe("obj.childAtIndex(1).roleDescription", '"AXRoleDescription: description"');
    3333
    3434          shouldBe("obj.childAtIndex(1).role", "'AXRole: AXGroup'");
    35           shouldBe("obj.childAtIndex(1).subrole", '"AXSubrole: AXDefinition"');
    36           shouldBe("obj.childAtIndex(1).roleDescription", '"AXRoleDescription: definition"');
     35          shouldBe("obj.childAtIndex(1).subrole", '"AXSubrole: AXDescription"');
     36          shouldBe("obj.childAtIndex(1).roleDescription", '"AXRoleDescription: description"');
    3737    }
    3838

  • trunk/LayoutTests/platform/mac/accessibility/lists-expected.txt

    r137484 r140974  
    6969------------
    7070AXRole: AXList
    71 AXSubrole: AXDefinitionList
    72 AXRoleDescription: definition list
     71AXSubrole: AXDescriptionList
     72AXRoleDescription: list
    7373AXChildren: <array of size 5>
    7474AXHelp:
    … …  
    277277------------
    278278AXRole: AXGroup
    279 AXSubrole: AXDefinition
    280 AXRoleDescription: definition
     279AXSubrole: AXDescription
     280AXRoleDescription: description
    281281AXChildren: <array of size 1>
    282282AXHelp:
    … …  
    325325------------
    326326AXRole: AXGroup
    327 AXSubrole: AXDefinition
    328 AXRoleDescription: definition
    329 AXChildren: <array of size 1>
    330 AXHelp:
    331 AXParent: <AXGroup>
    332 AXSize: NSSize: {729, 18}
    333 AXTitle:
    334 AXDescription:
    335 AXValue:
    336 AXFocused: 0
    337 AXEnabled: 1
    338 AXWindow: <AXGroup>
    339 AXSelectedTextMarkerRange: (null)
    340 AXStartTextMarker: <AXGroup>
    341 AXEndTextMarker: <AXGroup>
    342 AXVisited: 0
    343 AXLinkedUIElements: (null)
    344 AXSelected: 0
    345 AXBlockQuoteLevel: 0
    346 AXTopLevelUIElement: <AXGroup>
    347 AXARIABusy: 0
    348 
    349 ------------
    350 AXRole: AXGroup
    351 AXSubrole: AXDefinition
    352 AXRoleDescription: definition
    353 AXChildren: <array of size 1>
    354 AXHelp:
    355 AXParent: <AXGroup>
    356 AXSize: NSSize: {729, 18}
    357 AXTitle:
    358 AXDescription:
    359 AXValue:
    360 AXFocused: 0
    361 AXEnabled: 1
    362 AXWindow: <AXGroup>
    363 AXSelectedTextMarkerRange: (null)
    364 AXStartTextMarker: <AXGroup>
    365 AXEndTextMarker: <AXGroup>
    366 AXVisited: 0
    367 AXLinkedUIElements: (null)
    368 AXSelected: 0
    369 AXBlockQuoteLevel: 0
    370 AXTopLevelUIElement: <AXGroup>
    371 AXARIABusy: 0
    372 
    373 ------------
    374 
    375 
    376 
     327AXSubrole: AXDescription
     328AXRoleDescription: description
     329AXChildren: <array of size 1>
     330AXHelp:
     331AXParent: <AXGroup>
     332AXSize: NSSize: {729, 18}
     333AXTitle:
     334AXDescription:
     335AXValue:
     336AXFocused: 0
     337AXEnabled: 1
     338AXWindow: <AXGroup>
     339AXSelectedTextMarkerRange: (null)
     340AXStartTextMarker: <AXGroup>
     341AXEndTextMarker: <AXGroup>
     342AXVisited: 0
     343AXLinkedUIElements: (null)
     344AXSelected: 0
     345AXBlockQuoteLevel: 0
     346AXTopLevelUIElement: <AXGroup>
     347AXARIABusy: 0
     348
     349------------
     350AXRole: AXGroup
     351AXSubrole: AXDescription
     352AXRoleDescription: description
     353AXChildren: <array of size 1>
     354AXHelp:
     355AXParent: <AXGroup>
     356AXSize: NSSize: {729, 18}
     357AXTitle:
     358AXDescription:
     359AXValue:
     360AXFocused: 0
     361AXEnabled: 1
     362AXWindow: <AXGroup>
     363AXSelectedTextMarkerRange: (null)
     364AXStartTextMarker: <AXGroup>
     365AXEndTextMarker: <AXGroup>
     366AXVisited: 0
     367AXLinkedUIElements: (null)
     368AXSelected: 0
     369AXBlockQuoteLevel: 0
     370AXTopLevelUIElement: <AXGroup>
     371AXARIABusy: 0
     372
     373------------
     374
     375
     376

  • trunk/Source/WebCore/ChangeLog

    r140968 r140974  
     12013-01-28  James Craig  <james@cookiecrook.com>
     2
     3        HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
     4        https://bugs.webkit.org/show_bug.cgi?id=107650
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
     9
     10        Test: platform/mac/accessibility/definition-list-term.html:
     11        Test: accessibility/lists.html
     12
     13        * English.lproj/Localizable.strings:
     14        * accessibility/AccessibilityList.cpp:
     15        (WebCore::AccessibilityList::isDescriptionList):
     16        * accessibility/AccessibilityList.h:
     17        (AccessibilityList):
     18        * accessibility/AccessibilityObject.cpp:
     19        (WebCore::createARIARoleMap):
     20        * accessibility/AccessibilityObject.h:
     21        * accessibility/AccessibilityRenderObject.cpp:
     22        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
     23        * accessibility/mac/WebAccessibilityObjectWrapper.mm:
     24        (createAccessibilityRoleMap):
     25        (-[WebAccessibilityObjectWrapper subrole]):
     26        (-[WebAccessibilityObjectWrapper roleDescription]):
     27        * platform/LocalizedStrings.cpp:
     28        (WebCore::AXDefinitionText):
     29        (WebCore::AXDescriptionListTermText):
     30        (WebCore):
     31        (WebCore::AXDescriptionListDetailText):
     32        * platform/LocalizedStrings.h:
     33        (WebCore):
     34        * platform/blackberry/LocalizedStringsBlackBerry.cpp:
     35        (WebCore::AXDefinitionText):
     36        (WebCore::AXDescriptionListDetailText):
     37        (WebCore):
     38        (WebCore::AXDescriptionListTermText):
     39        * platform/efl/LocalizedStringsEfl.cpp:
     40        (WebCore::AXDefinitionText):
     41        (WebCore):
     42        (WebCore::AXDescriptionListTermText):
     43        (WebCore::AXDescriptionListDetailText):
     44        * platform/gtk/LocalizedStringsGtk.cpp:
     45        (WebCore::AXDefinitionText):
     46        (WebCore):
     47        (WebCore::AXDescriptionListTermText):
     48        (WebCore::AXDescriptionListDetailText):
     49        * platform/qt/LocalizedStringsQt.cpp:
     50        (WebCore::AXDefinitionText):
     51        (WebCore::AXDescriptionListTermText):
     52        (WebCore):
     53        (WebCore::AXDescriptionListDetailText):
     54
    1552013-01-28  Vladislav Kaznacheev  <kaznacheev@chromium.org>
    256

  • trunk/Source/WebCore/English.lproj/Localizable.strings

    r138860 r140974  
    611611"current movie time in seconds" = "current movie time in seconds";
    612612
    613 /* definition phrase */
     613/* definition detail */
    614614"definition" = "definition";
     615
     616/* description detail */
     617"description" = "description";
    615618
    616619/* An ARIA accessibility group that acts as an dialog. */

  • trunk/Source/WebCore/accessibility/AccessibilityList.cpp

    r140658 r140974  
    9999}
    100100
    101 bool AccessibilityList::isDefinitionList() const
     101bool AccessibilityList::isDescriptionList() const
    102102{
    103103    if (!m_renderer)

  • trunk/Source/WebCore/accessibility/AccessibilityList.h

    r124582 r140974  
    5151    bool isUnorderedList() const;
    5252    bool isOrderedList() const;
    53     bool isDefinitionList() const;
     53    bool isDescriptionList() const;
    5454
    5555    virtual AccessibilityRole roleValue() const { return ListRole; }

  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r138701 r140974  
    13941394        { "columnheader", ColumnHeaderRole },
    13951395        { "combobox", ComboBoxRole },
    1396         { "definition", DefinitionListDefinitionRole },
     1396        { "definition", DefinitionRole },
    13971397        { "document", DocumentRole },
    13981398        { "rowheader", RowHeaderRole },

  • trunk/Source/WebCore/accessibility/AccessibilityObject.h

    r140658 r140974  
    112112    ColumnHeaderRole,
    113113    ComboBoxRole,
    114     DefinitionListTermRole,
    115     DefinitionListDefinitionRole,
     114    DefinitionRole,
     115    DescriptionListTermRole,
     116    DescriptionListDetailRole,
    116117    DirectoryRole,
    117118    DisclosureTriangleRole,

  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

    r140658 r140974  
    24982498   
    24992499    if (node && node->hasTagName(ddTag))
    2500         return DefinitionListDefinitionRole;
     2500        return DescriptionListDetailRole;
    25012501   
    25022502    if (node && node->hasTagName(dtTag))
    2503         return DefinitionListTermRole;
     2503        return DescriptionListTermRole;
    25042504
    25052505    if (node && (node->hasTagName(rpTag) || node->hasTagName(rtTag)))

  • trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm

    r139663 r140974  
    112112#endif
    113113
    114 #ifndef NSAccessibilityDefinitionListSubrole
    115 #define NSAccessibilityDefinitionListSubrole @"AXDefinitionList"
     114#ifndef NSAccessibilityDescriptionListSubrole
     115#define NSAccessibilityDescriptionListSubrole @"AXDescriptionList"
    116116#endif
    117117
    … …  
    16011601        { TableHeaderContainerRole, NSAccessibilityGroupRole },
    16021602        { RowHeaderRole, NSAccessibilityGroupRole },
    1603         { DefinitionListDefinitionRole, NSAccessibilityGroupRole },
    1604         { DefinitionListTermRole, NSAccessibilityGroupRole },
     1603        { DefinitionRole, NSAccessibilityGroupRole },
     1604        { DescriptionListDetailRole, NSAccessibilityGroupRole },
     1605        { DescriptionListTermRole, NSAccessibilityGroupRole },
    16051606        { SliderThumbRole, NSAccessibilityValueIndicatorRole },
    16061607        { LandmarkApplicationRole, NSAccessibilityGroupRole },
    … …  
    17011702        if (listObject->isUnorderedList() || listObject->isOrderedList())
    17021703            return NSAccessibilityContentListSubrole;
    1703         if (listObject->isDefinitionList())
    1704             return NSAccessibilityDefinitionListSubrole;
     1704        if (listObject->isDescriptionList())
     1705            return NSAccessibilityDescriptionListSubrole;
    17051706    }
    17061707   
    … …  
    17511752        case TabPanelRole:
    17521753            return @"AXTabPanel";
    1753         case DefinitionListTermRole:
     1754        case DefinitionRole:
     1755            return @"AXDefinition";
     1756        case DescriptionListTermRole:
    17541757            return @"AXTerm";
    1755         case DefinitionListDefinitionRole:
    1756             return @"AXDefinition";
     1758        case DescriptionListDetailRole:
     1759            return @"AXDescription";
    17571760        // Default doesn't return anything, so roles defined below can be chosen.
    17581761        default:
    … …  
    18581861            case TabPanelRole:
    18591862                return AXARIAContentGroupText(@"ARIATabPanel");
    1860             case DefinitionListTermRole:
    1861                 return AXDefinitionListTermText();
    1862             case DefinitionListDefinitionRole:
    1863                 return AXDefinitionListDefinitionText();
     1863            case DefinitionRole:
     1864                return AXDefinitionText();
     1865            case DescriptionListTermRole:
     1866                return AXDescriptionListTermText();
     1867            case DescriptionListDetailRole:
     1868                return AXDescriptionListDetailText();
    18641869            case FooterRole:
    18651870                return AXFooterRoleDescriptionText();

  • trunk/Source/WebCore/platform/LocalizedStrings.cpp

    r138860 r140974  
    558558}
    559559
    560 String AXDefinitionListTermText()
    561 {
    562     return WEB_UI_STRING("term", "term word of a definition");
    563 }
    564 
    565 String AXDefinitionListDefinitionText()
    566 {
    567     return WEB_UI_STRING("definition", "definition phrase");
     560String AXDefinitionText()
     561{
     562    return WEB_UI_STRING("definition", "role description of ARIA definition role");
     563}
     564
     565String AXDescriptionListTermText()
     566{
     567    return WEB_UI_STRING("term", "term word of a description list");
     568}
     569
     570String AXDescriptionListDetailText()
     571{
     572    return WEB_UI_STRING("description", "description detail");
    568573}
    569574

  • trunk/Source/WebCore/platform/LocalizedStrings.h

    r138071 r140974  
    153153    String AXImageMapText();
    154154    String AXHeadingText();
    155     String AXDefinitionListTermText();
    156     String AXDefinitionListDefinitionText();
     155    String AXDefinitionText();
     156    String AXDescriptionListTermText();
     157    String AXDescriptionListDetailText();
    157158    String AXFooterRoleDescriptionText();
    158159    String AXFileUploadButtonText();

  • trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp

    r135836 r140974  
    389389}
    390390
    391 String AXDefinitionListDefinitionText()
    392 {
    393     notImplemented();
    394     return String();
    395 }
    396 
    397 String AXDefinitionListTermText()
     391String AXDefinitionText()
     392{
     393    notImplemented();
     394    return String();
     395}
     396
     397String AXDescriptionListDetailText()
     398{
     399    notImplemented();
     400    return String();
     401}
     402
     403String AXDescriptionListTermText()
    398404{
    399405    notImplemented();

  • trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp

    r140419 r140974  
    370370}
    371371
    372 String AXDefinitionListTermText()
     372String AXDefinitionText()
     373{
     374    return String::fromUTF8("definition");
     375}
     376
     377String AXDescriptionListTermText()
    373378{
    374379    return String::fromUTF8("term");
    375380}
    376381
    377 String AXDefinitionListDefinitionText()
    378 {
    379     return String::fromUTF8("definition");
     382String AXDescriptionListDetailText()
     383{
     384    return String::fromUTF8("description");
    380385}
    381386

  • trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

    r138204 r140974  
    408408}
    409409
    410 String AXDefinitionListTermText()
     410String AXDefinitionText()
     411{
     412    return String::fromUTF8(_("definition"));
     413}
     414
     415String AXDescriptionListTermText()
    411416{
    412417    return String::fromUTF8(_("term"));
    413418}
    414419
    415 String AXDefinitionListDefinitionText()
    416 {
    417     return String::fromUTF8(_("definition"));
     420String AXDescriptionListDetailText()
     421{
     422    return String::fromUTF8(_("description"));
    418423}
    419424

  • trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp

    r135836 r140974  
    380380}
    381381
    382 String AXDefinitionListTermText()
    383 {
    384     notImplemented();
    385     return String();
    386 }
    387 
    388 String AXDefinitionListDefinitionText()
     382String AXDefinitionText()
     383{
     384    notImplemented();
     385    return String();
     386}
     387
     388String AXDescriptionListTermText()
     389{
     390    notImplemented();
     391    return String();
     392}
     393
     394String AXDescriptionListDetailText()
    389395{
    390396    notImplemented();

  • trunk/Source/WebKit/chromium/ChangeLog

    r140971 r140974  
     12013-01-28  James Craig  <james@cookiecrook.com>
     2
     3        HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
     4        https://bugs.webkit.org/show_bug.cgi?id=107650
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
     9
     10        * public/WebAccessibilityRole.h:
     11        * src/AssertMatchingEnums.cpp:
     12        * src/LocalizedStrings.cpp:
     13        (WebCore::AXDefinitionText):
     14        (WebCore):
     15        (WebCore::AXDescriptionListTermText):
     16        (WebCore::AXDescriptionListDetailText):
     17
    1182013-01-28  Mike West  <mkwst@chromium.org>
    219

  • trunk/Source/WebKit/chromium/public/WebAccessibilityRole.h

    r140621 r140974  
    5757    WebAccessibilityRoleColumnHeader,
    5858    WebAccessibilityRoleComboBox,
    59     WebAccessibilityRoleDefinitionListTerm,
    60     WebAccessibilityRoleDefinitionListDefinition,
     59    WebAccessibilityRoleDefinition,
     60    WebAccessibilityRoleDescriptionListTerm,
     61    WebAccessibilityRoleDescriptionListDetail,
    6162    WebAccessibilityRoleDirectory,
    6263    WebAccessibilityRoleDisclosureTriangle,

  • trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp

    r140971 r140974  
    222222COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleMenuListPopup, MenuListPopupRole);
    223223COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleTableHeaderContainer, TableHeaderContainerRole);
    224 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDefinitionListTerm, DefinitionListTermRole);
    225 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDefinitionListDefinition, DefinitionListDefinitionRole);
     224COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDefinition, DefinitionRole);
     225COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDescriptionListTerm, DescriptionListTermRole);
     226COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDescriptionListDetail, DescriptionListDetailRole);
    226227COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleAnnotation, AnnotationRole);
    227228COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleSliderThumb, SliderThumbRole);

  • trunk/Source/WebKit/chromium/src/LocalizedStrings.cpp

    r138680 r140974  
    146146}
    147147
    148 String AXDefinitionListTermText()
     148String AXDefinitionText()
     149{
     150    notImplemented();
     151    return String("definition");
     152}
     153
     154String AXDescriptionListTermText()
    149155{
    150156    notImplemented();
    … …  
    152158}
    153159
    154 String AXDefinitionListDefinitionText()
    155 {
    156     notImplemented();
    157     return String("definition");
     160String AXDescriptionListDetailText()
     161{
     162    notImplemented();
     163    return String("description");
    158164}
    159165

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js

    r93259 r140974  
    2424 */
    2525
    26 function createDefinitionList(items) {
     26function createDescriptionList(items) {
    2727    var list = document.createElement('dl');
    2828    items.forEach(function(pair) {

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js

    r120669 r140974  
    177177        if (passingBuildName)
    178178            dlItems.push([document.createTextNode('Passed'), this._domForBuildName(builder, passingBuildName)]);
    179         result.appendChild(createDefinitionList(dlItems));
     179        result.appendChild(createDescriptionList(dlItems));
    180180
    181181        if (!passingBuildName)

  • trunk/Tools/ChangeLog

    r140970 r140974  
     12013-01-28  James Craig  <james@cookiecrook.com>
     2
     3        HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
     4        https://bugs.webkit.org/show_bug.cgi?id=107650
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Updating accessibility strings and accessors for DL/DT/DD.
     9
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
     11        (createDescriptionList):
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
     13        * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
     14
    1152013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
    216

  • trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp

    r140565 r140974  
    170170    case WebAccessibilityRoleTableHeaderContainer:
    171171        return result.append("TableHeaderContainer");
    172     case WebAccessibilityRoleDefinitionListTerm:
    173         return result.append("DefinitionListTerm");
    174     case WebAccessibilityRoleDefinitionListDefinition:
    175         return result.append("DefinitionListDefinition");
     172    case WebAccessibilityRoleDefinition:
     173        return result.append("Definition");
     174    case WebAccessibilityRoleDescriptionListTerm:
     175        return result.append("DescriptionListTerm");
     176    case WebAccessibilityRoleDescriptionListDetail:
     177        return result.append("DescriptionListDetail");
    176178    case WebAccessibilityRoleAnnotation:
    177179        return result.append("Annotation");
Note: See TracChangeset for help on using the changeset viewer.