Changeset 140992 in webkit

Timestamp:

Jan 28, 2013 12:36:12 PM (11 years ago)

Author:

tonyg@chromium.org

Message:

Don't use threaded HTML parser for data: URLs
​https://bugs.webkit.org/show_bug.cgi?id=108096

Reviewed by Eric Seidel.

data: URLs are currently loaded synchronously. Using the main thread parser for them preserves this behavior.
This fixes fast/dom/HTMLDocument/document-open-return-value.html and probably others.

No new tests because covered by existing tests.

• html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLParserOptions.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-28  Tony Gentilcore  <tonyg@chromium.org>
+
+        Don't use threaded HTML parser for data: URLs
+        https://bugs.webkit.org/show_bug.cgi?id=108096
+
+        Reviewed by Eric Seidel.
+
+        data: URLs are currently loaded synchronously. Using the main thread parser for them preserves this behavior.
+        This fixes fast/dom/HTMLDocument/document-open-return-value.html and probably others.
+
+        No new tests because covered by existing tests.
+
+        * html/parser/HTMLParserOptions.cpp:
+        (WebCore::HTMLParserOptions::HTMLParserOptions):
+
 2013-01-28  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLParserOptions.cpp

@@ -42 +42 @@
     usePreHTML5ParserQuirks = settings && settings->usePreHTML5ParserQuirks();
 #if ENABLE(THREADED_HTML_PARSER)
-    useThreading = settings && settings->threadedHTMLParser() && !document->url().isBlankURL();
+    // We force the main-thread parser for about:blank, javascript: and data: urls for compatibility
+    // with historical synchronous loading/parsing behavior of those schemes.
+    useThreading = settings && settings->threadedHTMLParser() && !document->url().isBlankURL() && !document->url().protocolIsData();
 #else
     useThreading = false;