Changeset 140993 in webkit

Timestamp:

Jan 28, 2013 12:43:33 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

getComputedStyle returns "left" instead of "none" for "float" on abspos elements
​https://bugs.webkit.org/show_bug.cgi?id=105836

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-01-28
Reviewed by Tony Chang.

If 'position' has the value absolute, page or fixed, and the value of float is
left or right, the box is absolutely positioned and the computed value of float is none.
​http://www.w3.org/TR/css3-positioning/#dis-pos-flo
This matches behavior of Firefox 18, Opera 12 and IE9.

Source/WebCore:

Test: fast/css/position-absolute-float.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

• fast/css/position-absolute-float-expected.txt: Added.
• fast/css/position-absolute-float.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/position-absolute-float-expected.txt (added)
• LayoutTests/fast/css/position-absolute-float.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-28  Uday Kiran  <udaykiran@motorola.com>
+
+        getComputedStyle returns "left" instead of "none" for "float" on abspos elements
+        https://bugs.webkit.org/show_bug.cgi?id=105836
+
+        Reviewed by Tony Chang.
+
+        If 'position' has the value absolute, page or fixed, and the value of float is
+        left or right, the box is absolutely positioned and the computed value of float is none.
+        http://www.w3.org/TR/css3-positioning/#dis-pos-flo
+        This matches behavior of Firefox 18, Opera 12 and IE9.
+
+        * fast/css/position-absolute-float-expected.txt: Added.
+        * fast/css/position-absolute-float.html: Added.
+
 2013-01-28  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-28  Uday Kiran  <udaykiran@motorola.com>
+
+        getComputedStyle returns "left" instead of "none" for "float" on abspos elements
+        https://bugs.webkit.org/show_bug.cgi?id=105836
+
+        Reviewed by Tony Chang.
+
+        If 'position' has the value absolute, page or fixed, and the value of float is
+        left or right, the box is absolutely positioned and the computed value of float is none.
+        http://www.w3.org/TR/css3-positioning/#dis-pos-flo
+        This matches behavior of Firefox 18, Opera 12 and IE9.
+
+        Test: fast/css/position-absolute-float.html
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+
 2013-01-28  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -1861 +1861 @@
             return cssValuePool().createValue(style->order(), CSSPrimitiveValue::CSS_NUMBER);
         case CSSPropertyFloat:
+            if (style->display() != NONE && style->hasOutOfFlowPosition())
+                return cssValuePool().createIdentifierValue(CSSValueNone);
             return cssValuePool().createValue(style->floating());
         case CSSPropertyFont: {