Changeset 141067 in webkit

Timestamp:

Jan 28, 2013 11:48:48 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Texmap] Refactor code related to debug border and repaint count.
​https://bugs.webkit.org/show_bug.cgi?id=105787

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-28
Reviewed by Noam Rosenthal.

It is a follow-up patch not to change layout test results.

The previous patch sets GraphicsLayer::m_usingTiledLayer to true when using a
backing store. When the variable is true, dumpLayer() adds (usingTiledLayer 1),
but most of ports don't set m_usingTiledLayer to true. So we don't use
m_usingTiledLayer to match the test results of other ports.

After this patch, Texture Mapper draws debug visuals for a tiled backing
with different color from safari.

No new tests. Debug feature, not covered in tests.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCountIfNeeded):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-28  Huang Dongsung  <luxtella@company100.net>
+
+        [Texmap] Refactor code related to debug border and repaint count.
+        https://bugs.webkit.org/show_bug.cgi?id=105787
+
+        Reviewed by Noam Rosenthal.
+
+        It is a follow-up patch not to change layout test results.
+
+        The previous patch sets GraphicsLayer::m_usingTiledLayer to true when using a
+        backing store. When the variable is true, dumpLayer() adds (usingTiledLayer 1),
+        but most of ports don't set m_usingTiledLayer to true. So we don't use
+        m_usingTiledLayer to match the test results of other ports.
+
+        After this patch, Texture Mapper draws debug visuals for a tiled backing
+        with different color from safari.
+
+        No new tests. Debug feature, not covered in tests.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCountIfNeeded):
+
 2013-01-28  Elliott Sprehn  <esprehn@chromium.org>
 

trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp

@@ -414 +414 @@
         return;
 
-    m_usingTiledLayer = shouldHaveBackingStore();
-    updateDebugIndicators();
+    if (isShowingDebugBorder())
+        updateDebugIndicators();
 
     // When this has its own backing store (e.g. Qt WK1), update the repaint count before calling TextureMapperLayer::flushCompositingStateForThisLayerOnly().