Changeset 141107 in webkit


Ignore:
Timestamp:
Jan 29, 2013 6:48:41 AM (11 years ago)
Author:
michael.bruning@digia.com
Message:

[Qt][WK1] Fix QObject Bridge tests expected output.
https://bugs.webkit.org/show_bug.cgi?id=107827

Reviewed by Simon Hausmann.

The "not a function" TypeError now includes the call that caused the error.
Correct expected values accordingly.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::connectAndDisconnect):

Location:
trunk/Source/WebKit/qt
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/qt/ChangeLog

    r141040 r141107  
     12013-01-29  Michael Brüning  <michael.bruning@digia.com>
     2
     3        [Qt][WK1] Fix QObject Bridge tests expected output.
     4        https://bugs.webkit.org/show_bug.cgi?id=107827
     5
     6        Reviewed by Simon Hausmann.
     7
     8        The "not a function" TypeError now includes the call that caused the error.
     9        Correct expected values accordingly.
     10
     11        * tests/qobjectbridge/tst_qobjectbridge.cpp:
     12        (tst_QObjectBridge::connectAndDisconnect):
     13
    1142013-01-28  Huang Dongsung  <luxtella@company100.net>
    215
  • trunk/Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp

    r134236 r141107  
    15731573        QString ret = evalJS("(function() { }).connect()", type);
    15741574        QCOMPARE(type, sError);
    1575         QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
     1575        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating '(function() { }).connect()')"));
    15761576    }
    15771577    {
     
    15791579        QString ret = evalJS("var o = { }; o.connect = Function.prototype.connect;  o.connect()", type);
    15801580        QCOMPARE(type, sError);
    1581         QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
     1581        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating 'o.connect()')"));
    15821582    }
    15831583
     
    15861586        QString ret = evalJS("(function() { }).connect(123)", type);
    15871587        QCOMPARE(type, sError);
    1588         QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
     1588        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating '(function() { }).connect(123)')"));
    15891589    }
    15901590    {
     
    15921592        QString ret = evalJS("var o = { }; o.connect = Function.prototype.connect;  o.connect(123)", type);
    15931593        QCOMPARE(type, sError);
    1594         QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function"));
     1594        QCOMPARE(ret, QLatin1String("TypeError: 'undefined' is not a function (evaluating 'o.connect(123)')"));
    15951595    }
    15961596
Note: See TracChangeset for help on using the changeset viewer.