Changeset 141270 in webkit

Timestamp:

Jan 30, 2013 7:12:28 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Sidebar splitter is invisible in Elements and Sources panels
​https://bugs.webkit.org/show_bug.cgi?id=108331

Patch by Vladislav Kaznacheev <​kaznacheev@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.

This was a regression caused by ​https://bugs.webkit.org/show_bug.cgi?id=108181.
The splitter element did not get the correct class at the initialization.

• inspector/front-end/SidebarView.js:

(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarPosition):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/SidebarView.js (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-30  Vladislav Kaznacheev  <kaznacheev@chromium.org>
+
+        Web Inspector: Sidebar splitter is invisible in Elements and Sources panels
+        https://bugs.webkit.org/show_bug.cgi?id=108331
+
+        Reviewed by Pavel Feldman.
+
+        This was a regression caused by https://bugs.webkit.org/show_bug.cgi?id=108181.
+        The splitter element did not get the correct class at the initialization.
+
+        * inspector/front-end/SidebarView.js:
+        (WebInspector.SidebarView):
+        (WebInspector.SidebarView.prototype._updateSidebarPosition):
+
 2013-01-30  Dmitry Zvorygin  <zvorygin@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/SidebarView.js

@@ -47 +47 @@
     this._sidebarPosition = sidebarPosition || WebInspector.SidebarView.SidebarPosition.Start;
     this.setSecondIsSidebar(this._sidebarPosition === WebInspector.SidebarView.SidebarPosition.End);
-    this._updateSidebarPosition();
+    this._updateSidebarPosition(true);
 }
 
@@ -99 +99 @@
     },
 
-    _updateSidebarPosition: function()
+    /**
+     * @param {boolean=} force
+     */
+    _updateSidebarPosition: function(force)
     {
         var verticalSplit = true;
@@ -105 +108 @@
             verticalSplit = this.element.offsetHeight < this.element.offsetWidth;
 
-        if (verticalSplit === this.isVertical())
+        if (!force && verticalSplit === this.isVertical())
             return;