Changeset 141281 in webkit

Timestamp:

Jan 30, 2013 10:20:30 AM (11 years ago)

Author:

jer.noble@apple.com

Message:

MediaPlayerPrivateQTKit claims it supports application/x-diskcopy, breaking downloads.
​https://bugs.webkit.org/show_bug.cgi?id=108237

Reviewed by Eric Carlson.

Disclaim any non-'video/' or 'audio/' types which QTKit purports to support.

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::addFileTypesToCache):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-29  Jer Noble  <jer.noble@apple.com>
+
+        MediaPlayerPrivateQTKit claims it supports application/x-diskcopy, breaking downloads.
+        https://bugs.webkit.org/show_bug.cgi?id=108237
+
+        Reviewed by Eric Carlson.
+
+        Disclaim any non-'video/' or 'audio/' types which QTKit purports to support.
+
+        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+        (WebCore::addFileTypesToCache):
+
 2013-01-30  Florin Malita  <fmalita@chromium.org>
 

trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm

@@ -1477 +1477 @@
             unsigned count = typesForExtension.size();
             for (unsigned ndx = 0; ndx < count; ++ndx) {
-                if (!cache.contains(typesForExtension[ndx]))
-                    cache.add(typesForExtension[ndx]);
+                String& type = typesForExtension[ndx];
+
+                // QTKit will return non-video MIME types which it claims to support, but which we
+                // do not support in the <video> element. Disclaim all non video/ or audio/ types.
+                if (!type.startsWith("video/") && !type.startsWith("audio/"))
+                    continue;
+
+                if (!cache.contains(type))
+                    cache.add(type);
             }
         }