Changeset 141393 in webkit

Timestamp:

Jan 31, 2013 2:52:41 AM (11 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: test that nodes from the same detached DOM tree will get into one group in heap snapshot
​https://bugs.webkit.org/show_bug.cgi?id=108202

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html

• inspector/front-end/JSHeapSnapshot.js:

(WebInspector.JSHeapSnapshotNode.prototype.className): removed unnecessary i18n.

LayoutTests:

Test that JS wrappers for all DOM nodes from the same detached DOM tree will get into
single "Detached DOM Tree" entry in the JS heap snapshot.

• http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.importScript):

• inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Added.
• inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Added. I started

with writing simplified version of WebInspector.JSHeapSnapshot just for tests
but it soon it became clear that we would need to reimplement too much functionality
of WebInspector.JSHeapSnapshot so I decided not to reinvent the wheel and just import
original heap snapshot model.

• inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Added.

(InspectorTest.takeHeapSnapshot):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js (modified) (1 diff)
• LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt (added)
• LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html (added)
• LayoutTests/inspector-protocol/heap-profiler/resources/heap-snapshot-common.js (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/JSHeapSnapshot.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-30  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: test that nodes from the same detached DOM tree will get into one group in heap snapshot
+        https://bugs.webkit.org/show_bug.cgi?id=108202
+
+        Reviewed by Vsevolod Vlasov.
+
+        Test that JS wrappers for all DOM nodes from the same detached DOM tree will get into
+        single "Detached DOM Tree" entry in the JS heap snapshot.
+
+        * http/tests/inspector-protocol/resources/InspectorTest.js:
+        (InspectorTest.importScript):
+        * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Added.
+        * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Added. I started
+        with writing simplified version of WebInspector.JSHeapSnapshot just for tests
+        but it soon it became clear that we would need to reimplement too much functionality
+        of WebInspector.JSHeapSnapshot so I decided not to reinvent the wheel and just import
+        original heap snapshot model.
+        * inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Added.
+        (InspectorTest.takeHeapSnapshot):
+
 2013-01-31  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js

@@ -90 +90 @@
 }
 
+
+/**
+ * @param {string} scriptName
+ */
+InspectorTest.importScript = function(scriptName)
+{
+    var xhr = new XMLHttpRequest();
+    xhr.open("GET", scriptName, false);
+    xhr.send(null);
+    window.eval(xhr.responseText);
+}
+
 window.addEventListener("message", function(event) {
     try {

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-01-30  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: test that nodes from the same detached DOM tree will get into one group in heap snapshot
+        https://bugs.webkit.org/show_bug.cgi?id=108202
+
+        Reviewed by Vsevolod Vlasov.
+
+        Test: inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
+
+        * inspector/front-end/JSHeapSnapshot.js:
+        (WebInspector.JSHeapSnapshotNode.prototype.className): removed unnecessary i18n.
+
 2013-01-31  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/JSHeapSnapshot.js

@@ -323 +323 @@
         switch (type) {
         case "hidden":
-            return WebInspector.UIString("(system)");
+            return "(system)";
         case "object":
         case "native":
             return this.name();
         case "code":
-            return WebInspector.UIString("(compiled code)");
+            return "(compiled code)";
         default:
             return "(" + type + ")";