Changeset 141399 in webkit

Timestamp:

Jan 31, 2013 4:01:01 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: text-editor-ctrl-movements.html timeouts on mac
​https://bugs.webkit.org/show_bug.cgi?id=108440

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.

Use "alt-arrows" key shortcuts to jump over words instead of
"ctrl-arrows" on Mac platform.

• inspector/editor/text-editor-word-jumps-expected.txt: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt.
• inspector/editor/text-editor-word-jumps.html: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements.html.
• platform/chromium/TestExpectations: Do not skip this test anymore.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/editor/text-editor-word-jumps-expected.txt (moved) (moved from trunk/LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt)
• inspector/editor/text-editor-word-jumps.html (moved) (moved from trunk/LayoutTests/inspector/editor/text-editor-ctrl-movements.html) (6 diffs)
• platform/chromium/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-01-31  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: text-editor-ctrl-movements.html timeouts on mac
+        https://bugs.webkit.org/show_bug.cgi?id=108440
+
+        Reviewed by Pavel Feldman.
+
+        Use "alt-arrows" key shortcuts to jump over words instead of
+        "ctrl-arrows" on Mac platform.
+
+        * inspector/editor/text-editor-word-jumps-expected.txt: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt.
+        * inspector/editor/text-editor-word-jumps.html: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements.html.
+        * platform/chromium/TestExpectations: Do not skip this test anymore.
+
 2013-01-30  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/LayoutTests/inspector/editor/text-editor-word-jumps.html

@@ -21 +21 @@
 
     InspectorTest.addResult(textEditor.text());
+    const wordJumpModifier = WebInspector.isMac() ? "altKey" : "ctrlKey";
 
     function dumpEditorSelection()
@@ -54 +55 @@
             do {
                 oldSelection = selection;
-                eventSender.keyDown("rightArrow", ["ctrlKey"]);
+                eventSender.keyDown("rightArrow", [wordJumpModifier]);
                 selection = dumpEditorSelection();
             } while (selection.compareTo(oldSelection) !== 0);
@@ -67 +68 @@
             do {
                 oldSelection = selection;
-                eventSender.keyDown("leftArrow", ["ctrlKey"]);
+                eventSender.keyDown("leftArrow", [wordJumpModifier]);
                 selection = dumpEditorSelection();
             } while (selection.compareTo(oldSelection) !== 0);
@@ -80 +81 @@
             do {
                 oldSelection = selection;
-                eventSender.keyDown("rightArrow", ["ctrlKey", "shiftKey"]);
+                eventSender.keyDown("rightArrow", [wordJumpModifier, "shiftKey"]);
                 selection = dumpEditorSelection();
             } while (selection.collapseToEnd().compareTo(oldSelection.collapseToEnd()) !== 0);
@@ -93 +94 @@
             do {
                 oldSelection = selection;
-                eventSender.keyDown("leftArrow", ["ctrlKey", "shiftKey"]);
+                eventSender.keyDown("leftArrow", [wordJumpModifier, "shiftKey"]);
                 selection = dumpEditorSelection();
             } while (selection.collapseToEnd().compareTo(oldSelection.collapseToEnd()) !== 0);
@@ -105 +106 @@
             InspectorTest.addResult(textEditor.text());
             do {
-                eventSender.keyDown("\b", ["ctrlKey"]);
+                eventSender.keyDown("\b", [wordJumpModifier]);
                 InspectorTest.addResult("===============");
                 InspectorTest.addResult(textEditor.text() + "<<");

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -1070 +1070 @@
 webkit.org/b/75647 http/tests/inspector/network/download.html [ Pass Timeout Failure ]
 
-# Timing out after http://trac.webkit.org/changeset/141245
-webkit.org/b/107944 inspector/editor/text-editor-ctrl-movements.html [ Pass Timeout ]
-
 # -----------------------------------------------------------------
 # Editing tests