Changeset 141405 in webkit
- Timestamp:
- Jan 31, 2013 5:01:58 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r141403 r141405 1 2013-01-31 Vineet Chaudhary <rgf748@motorola.com> 2 3 formMethod to have empty string as default value and 'get' as invalid. 4 https://bugs.webkit.org/show_bug.cgi?id=108263 5 6 Reviewed by Kent Tamura. 7 8 The spec says formmethod should only have an invalid value default, not a missing value default. 9 Spec: http://www.whatwg.org/specs/web-apps/current-work/#form-submission-0 10 http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formmethod 11 12 * fast/forms/formmethod-attribute-test-expected.txt: Added. 13 * fast/forms/formmethod-attribute-test.html: Added. 14 * fast/forms/submit-form-attributes-expected.txt: 15 * fast/forms/submit-form-attributes.html: Modified test to behave as expected. 16 1 17 2013-01-31 Andrey Adaikin <aandrey@chromium.org> 2 18 -
trunk/LayoutTests/fast/forms/submit-form-attributes-expected.txt
r96484 r141405 7 7 PASS input.formAction is "" 8 8 PASS input.formEnctype is "application/x-www-form-urlencoded" 9 PASS input.formMethod is " get"9 PASS input.formMethod is "" 10 10 PASS input.formTarget is "" 11 11 PASS input.formAction is "http://localhost/" … … 30 30 PASS input.getAttribute("formEnctype") is null 31 31 PASS input.formEnctype is "application/x-www-form-urlencoded" 32 PASS input.formMethod is " get"32 PASS input.formMethod is "" 33 33 PASS input.getAttribute("formMethod") is null 34 34 PASS input.formMethod is "get" … … 62 62 PASS button.formAction is "" 63 63 PASS button.formEnctype is "application/x-www-form-urlencoded" 64 PASS button.formMethod is " get"64 PASS button.formMethod is "" 65 65 PASS button.formTarget is "" 66 66 PASS button.formAction is "http://localhost/" … … 85 85 PASS button.getAttribute("formEnctype") is null 86 86 PASS button.formEnctype is "application/x-www-form-urlencoded" 87 PASS button.formMethod is " get"87 PASS button.formMethod is "" 88 88 PASS button.getAttribute("formMethod") is null 89 89 PASS button.formMethod is "get" -
trunk/LayoutTests/fast/forms/submit-form-attributes.html
r107781 r141405 16 16 shouldBe('input.formAction', '""'); 17 17 shouldBe('input.formEnctype', '"application/x-www-form-urlencoded"'); 18 shouldBe ('input.formMethod', '"get"');18 shouldBeEqualToString("input.formMethod", ""); 19 19 shouldBe('input.formTarget', '""'); 20 20 … … 61 61 shouldBe('input.formEnctype', '"application/x-www-form-urlencoded"'); 62 62 input.formMethod = null; 63 shouldBe ('input.formMethod', '"get"');63 shouldBeEqualToString("input.formMethod", ""); 64 64 shouldBe('input.getAttribute("formMethod")', 'null'); 65 65 input.setAttribute('formMethod', null); … … 113 113 shouldBe('button.formAction', '""'); 114 114 shouldBe('button.formEnctype', '"application/x-www-form-urlencoded"'); 115 shouldBe ('button.formMethod', '"get"');115 shouldBeEqualToString("button.formMethod", ""); 116 116 shouldBe('button.formTarget', '""'); 117 117 … … 158 158 shouldBe('button.formEnctype', '"application/x-www-form-urlencoded"'); 159 159 button.formMethod = null; 160 shouldBe ('button.formMethod', '"get"');160 shouldBeEqualToString("button.formMethod", ""); 161 161 shouldBe('button.getAttribute("formMethod")', 'null'); 162 162 button.setAttribute('formMethod', null); -
trunk/Source/WebCore/ChangeLog
r141404 r141405 1 2013-01-31 Vineet Chaudhary <rgf748@motorola.com> 2 3 formMethod to have empty string as default value and 'get' as invalid. 4 https://bugs.webkit.org/show_bug.cgi?id=108263 5 6 Reviewed by Kent Tamura. 7 8 The spec says formmethod should only have an invalid value default, not a missing value default. 9 Spec: http://www.whatwg.org/specs/web-apps/current-work/#form-submission-0 10 http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formmethod 11 12 Test: fast/forms/formmethod-attribute-test.html 13 14 * html/HTMLFormControlElement.cpp: For the missing formMethod attr return empty string. 15 (WebCore::HTMLFormControlElement::formMethod): 16 1 17 2013-01-20 Kondapally Kalyan <kalyan.kondapally@intel.com> 2 18 -
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
r141292 r141405 83 83 String HTMLFormControlElement::formMethod() const 84 84 { 85 return FormSubmission::Attributes::methodString(FormSubmission::Attributes::parseMethodType(fastGetAttribute(formmethodAttr))); 85 const AtomicString& formMethodAttr = fastGetAttribute(formmethodAttr); 86 if (formMethodAttr.isNull()) 87 return emptyString(); 88 return FormSubmission::Attributes::methodString(FormSubmission::Attributes::parseMethodType(formMethodAttr)); 86 89 } 87 90
Note: See TracChangeset
for help on using the changeset viewer.