Changeset 141511 in webkit


Ignore:
Timestamp:
Jan 31, 2013 5:21:56 PM (11 years ago)
Author:
haraken@chromium.org
Message:

[V8] Pass an Isolate to GetTemplate() in CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=108445

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):

Location:
trunk/Source/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r141509 r141511  
     12013-01-31  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] Pass an Isolate to GetTemplate() in CodeGeneratorV8.pm
     4        https://bugs.webkit.org/show_bug.cgi?id=108445
     5
     6        Reviewed by Adam Barth.
     7
     8        No tests. No change in behavior.
     9
     10        * bindings/scripts/CodeGeneratorV8.pm:
     11        (GenerateDomainSafeFunctionGetter):
     12        (GenerateDomainSafeFunctionSetter):
     13        (GenerateNormalAttrGetter):
     14        (GenerateNamedConstructorCallback):
     15        (GenerateImplementation):
     16        * bindings/scripts/test/V8/V8Float64Array.cpp:
     17        (WebCore::ConfigureV8Float64ArrayTemplate):
     18        * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
     19        (WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
     20        (WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
     21        * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
     22        (WebCore::V8TestNamedConstructorConstructor::GetTemplate):
     23        * bindings/scripts/test/V8/V8TestNode.cpp:
     24        (WebCore::ConfigureV8TestNodeTemplate):
     25
    1262013-01-31  Kentaro Hara  <haraken@chromium.org>
    227

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r141502 r141511  
    786786{
    787787    static v8::Persistent<v8::FunctionTemplate> privateTemplate = v8::Persistent<v8::FunctionTemplate>::New($newTemplateString);
    788     v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(${v8InterfaceName}::GetTemplate());
     788    v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(${v8InterfaceName}::GetTemplate(info.GetIsolate()));
    789789    if (holder.IsEmpty()) {
    790790        // can only reach here by 'object.__proto__.func', and it should passed
    … …  
    816816static void ${interfaceName}DomainSafeFunctionSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
    817817{
    818     v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(${v8InterfaceName}::GetTemplate());
     818    v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(${v8InterfaceName}::GetTemplate(info.GetIsolate()));
    819819    if (holder.IsEmpty())
    820820        return;
    … …  
    910910            # perform lookup first
    911911            push(@implContentDecls, <<END);
    912     v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(${v8InterfaceName}::GetTemplate());
     912    v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(${v8InterfaceName}::GetTemplate(info.GetIsolate()));
    913913    if (holder.IsEmpty())
    914914        return v8Undefined();
    … …  
    21992199    instance->SetInternalFieldCount(${v8InterfaceName}::internalFieldCount);
    22002200    result->SetClassName(v8::String::NewSymbol("${interfaceName}"));
    2201     result->Inherit(${v8InterfaceName}::GetTemplate());
     2201    result->Inherit(${v8InterfaceName}::GetTemplate(isolate));
    22022202
    22032203    cachedTemplate = v8::Persistent<v8::FunctionTemplate>::New(result);
    … …  
    26492649        AddToImplIncludes("V8${parent}.h");
    26502650        $parentClass = "V8" . $parent;
    2651         $parentClassTemplate = $parentClass . "::GetTemplate()";
     2651        $parentClassTemplate = $parentClass . "::GetTemplate(isolate)";
    26522652        last;
    26532653    }

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp

    r141105 r141511  
    111111
    112112    v8::Local<v8::Signature> defaultSignature;
    113     defaultSignature = V8DOMConfiguration::configureTemplate(desc, "Float64Array", V8ArrayBufferView::GetTemplate(), V8Float64Array::internalFieldCount,
     113    defaultSignature = V8DOMConfiguration::configureTemplate(desc, "Float64Array", V8ArrayBufferView::GetTemplate(isolate), V8Float64Array::internalFieldCount,
    114114        0, 0,
    115115        V8Float64ArrayCallbacks, WTF_ARRAY_LENGTH(V8Float64ArrayCallbacks));

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp

    r141105 r141511  
    9494{
    9595    static v8::Persistent<v8::FunctionTemplate> privateTemplate = v8::Persistent<v8::FunctionTemplate>::New(v8::FunctionTemplate::New(TestActiveDOMObjectV8Internal::postMessageCallback, v8Undefined(), v8::Signature::New(V8TestActiveDOMObject::GetRawTemplate(info.GetIsolate()))));
    96     v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(V8TestActiveDOMObject::GetTemplate());
     96    v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(V8TestActiveDOMObject::GetTemplate(info.GetIsolate()));
    9797    if (holder.IsEmpty()) {
    9898        // can only reach here by 'object.__proto__.func', and it should passed
    … …  
    115115static void TestActiveDOMObjectDomainSafeFunctionSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
    116116{
    117     v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(V8TestActiveDOMObject::GetTemplate());
     117    v8::Handle<v8::Object> holder = info.This()->FindInstanceInPrototypeChain(V8TestActiveDOMObject::GetTemplate(info.GetIsolate()));
    118118    if (holder.IsEmpty())
    119119        return;

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp

    r141105 r141511  
    113113    instance->SetInternalFieldCount(V8TestNamedConstructor::internalFieldCount);
    114114    result->SetClassName(v8::String::NewSymbol("TestNamedConstructor"));
    115     result->Inherit(V8TestNamedConstructor::GetTemplate());
     115    result->Inherit(V8TestNamedConstructor::GetTemplate(isolate));
    116116
    117117    cachedTemplate = v8::Persistent<v8::FunctionTemplate>::New(result);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp

    r141105 r141511  
    8585
    8686    v8::Local<v8::Signature> defaultSignature;
    87     defaultSignature = V8DOMConfiguration::configureTemplate(desc, "TestNode", V8Node::GetTemplate(), V8TestNode::internalFieldCount,
     87    defaultSignature = V8DOMConfiguration::configureTemplate(desc, "TestNode", V8Node::GetTemplate(isolate), V8TestNode::internalFieldCount,
    8888        0, 0,
    8989        0, 0);
Note: See TracChangeset for help on using the changeset viewer.