Changeset 141561 in webkit

Timestamp:

Feb 1, 2013 1:52:10 AM (11 years ago)

Author:

aandrey@chromium.org

Message:

Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
​https://bugs.webkit.org/show_bug.cgi?id=108591

Reviewed by Pavel Feldman.

Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.

• inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/CanvasProfileView.js (modified) (2 diffs)
• inspector/front-end/ProfilesPanel.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-01  Andrey Adaikin  <aandrey@chromium.org>
+
+        Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
+        https://bugs.webkit.org/show_bug.cgi?id=108591
+
+        Reviewed by Pavel Feldman.
+
+        Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
+        Before we were sending the command only upon deleting an existing view of a profile, so we  would not
+        sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
+        Drive-by: fixed an odd formatting of property functions.
+
+        * inspector/front-end/CanvasProfileView.js:
+        (WebInspector.CanvasProfileView.prototype.dispose):
+        (WebInspector.CanvasProfileHeader.prototype.reset):
+        * inspector/front-end/ProfilesPanel.js:
+        (WebInspector.ProfileHeader.prototype.reset):
+        (WebInspector.ProfileHeader.prototype.load):
+        (WebInspector.ProfileHeader.prototype.canSaveToFile):
+        (WebInspector.ProfileHeader.prototype.saveToFile):
+        (WebInspector.ProfileHeader.prototype.loadFromFile):
+        (WebInspector.ProfileHeader.prototype.fromFile):
+        (WebInspector.ProfilesPanel):
+        (WebInspector.ProfilesPanel.prototype._reset):
+        (WebInspector.ProfilesPanel.prototype._removeProfileHeader):
+
 2013-02-01  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/inspector/front-end/CanvasProfileView.js

@@ -104 +104 @@
         this._logGridNodes = [];
         this._linkifier.reset();
-        CanvasAgent.dropTraceLog(this._traceLogId);
     },
 
@@ -768 +767 @@
 
     /**
+     * @override
+     */
+    reset: function()
+    {
+        if (this._traceLogId)
+            CanvasAgent.dropTraceLog(this._traceLogId);
+    },
+
+    /**
      * @param {CanvasAgent.TraceLog=} traceLog
      */

trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js

@@ -185 +185 @@
     },
 
+    reset: function()
+    {
+    },
+
     /**
      * @param {Function} callback
      */
-    load: function(callback) { },
+    load: function(callback)
+    {
+    },
 
     /**
      * @return {boolean}
      */
-    canSaveToFile: function() { return false; },
-
-    saveToFile: function() { throw new Error("Needs implemented"); },
+    canSaveToFile: function()
+    {
+        return false;
+    },
+
+    saveToFile: function()
+    {
+        throw new Error("Needs implemented");
+    },
 
     /**
      * @param {File} file
      */
-    loadFromFile: function(file) { throw new Error("Needs implemented"); },
+    loadFromFile: function(file)
+    {
+        throw new Error("Needs implemented");
+    },
 
     /**
      * @return {boolean}
      */
-    fromFile: function() { return this._fromFile; }
+    fromFile: function()
+    {
+        return this._fromFile;
+    }
 }
 
@@ -265 +283 @@
     this._profileViewStatusBarItemsContainer.className = "status-bar-items";
 
+    /** @type {!Array.<!WebInspector.ProfileHeader>} */
     this._profiles = [];
     this._profilerEnabled = !Capabilities.profilerCausesRecompilation;
@@ -401 +420 @@
                     view.dispose();
             }
+            this._profiles[i].reset();
         }
         delete this.visibleView;
@@ -595 +615 @@
                 profile = this._profiles[i];
                 this._profiles.splice(i, 1);
+                profile.reset();
                 break;
             }