Changeset 141563 in webkit

Timestamp:

Feb 1, 2013 2:07:25 AM (11 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Sources panel navigator reveal and expand fixes.
​https://bugs.webkit.org/show_bug.cgi?id=108584

Reviewed by Pavel Feldman.

Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.

• inspector/front-end/NavigatorView.js:

(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addUISourceCode):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/NavigatorView.js (modified) (2 diffs)
• inspector/front-end/ScriptsPanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-01  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Sources panel navigator reveal and expand fixes.
+        https://bugs.webkit.org/show_bug.cgi?id=108584
+
+        Reviewed by Pavel Feldman.
+
+        Navigator folders are not expanded by default anymore.
+        Made domain folder expanded for inspected page main frame domain.
+        UISourceCodes are now added to navigator before editor container
+        so that they could be revealed if editor container decides to show them.
+
+        * inspector/front-end/NavigatorView.js:
+        (WebInspector.BaseNavigatorTreeElement.prototype.onattach):
+        (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._addUISourceCode):
+
 2013-02-01  Andrey Adaikin  <aandrey@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/NavigatorView.js

@@ -461 +461 @@
         this.titleElement.appendChild(this._titleTextNode);
         this.listItemElement.appendChild(this.titleElement);
-        this.expand();
     },
 
@@ -537 +536 @@
     {
         WebInspector.BaseNavigatorTreeElement.prototype.onattach.call(this);
-        if (this.isDomain && this.titleText != WebInspector.inspectedPageDomain)
+        if (this.isDomain && this.titleText === WebInspector.inspectedPageDomain)
+            this.expand();
+        else
             this.collapse();
-        else
-            this.expand();
     },
 

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -246 +246 @@
         if (uiSourceCode.project().isServiceProject())
             return;
+        this._navigator.addUISourceCode(uiSourceCode);
         this._editorContainer.addUISourceCode(uiSourceCode);
-        this._navigator.addUISourceCode(uiSourceCode);
         // Replace debugger script-based uiSourceCode with a network-based one.
         var currentUISourceCode = this._currentUISourceCode;