Changeset 141574 in webkit


Ignore:
Timestamp:
Feb 1, 2013 3:26:17 AM (11 years ago)
Author:
aandrey@chromium.org
Message:

Web Inspector: fix jscompiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=108604

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleGroup.prototype.addMessage):

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextSubMenuItem):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype._isDockedToBottom):

Location:
trunk/Source/WebCore
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r141571 r141574  
     12013-02-01  Andrey Adaikin  <aandrey@chromium.org>
     2
     3        Web Inspector: fix jscompiler warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=108604
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/front-end/ConsoleView.js:
     9        (WebInspector.ConsoleGroup.prototype.addMessage):
     10        * inspector/front-end/ContextMenu.js:
     11        (WebInspector.ContextSubMenuItem):
     12        * inspector/front-end/ImageView.js:
     13        (WebInspector.ImageView.prototype._copyImageURL):
     14        (WebInspector.ImageView.prototype._openInNewTab):
     15        * inspector/front-end/NetworkPanel.js:
     16        (WebInspector.NetworkLogView.prototype._clearBrowserCache):
     17        (WebInspector.NetworkLogView.prototype._clearBrowserCookies):
     18        * inspector/front-end/ResourcesPanel.js:
     19        (WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
     20        * inspector/front-end/ScriptsNavigator.js:
     21        (WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
     22        (WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
     23        (WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
     24        (WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
     25        * inspector/front-end/Toolbar.js:
     26        (WebInspector.Toolbar.prototype._isDockedToBottom):
     27
    1282013-02-01  Jae Hyun Park  <jae.park@company100.net>
    229

  • trunk/Source/WebCore/inspector/front-end/ConsoleView.js

    r141269 r141574  
    821821                groupElement.addStyleClass("collapsed");
    822822        } else
    823             this.messagesElement.insertBefore(element, node);
     823            this.messagesElement.insertBefore(element, node || null);
    824824
    825825        if (element.previousSibling && message.originatingCommand && element.previousSibling.command === message.originatingCommand)

  • trunk/Source/WebCore/inspector/front-end/ContextMenu.js

    r141269 r141574  
    9898{
    9999    WebInspector.ContextMenuItem.call(this, topLevelMenu, "subMenu", label, disabled);
     100    /** @type {!Array.<!WebInspector.ContextMenuItem>} */
    100101    this._items = [];
    101102}
    … …  
    104105    /**
    105106     * @param {string} label
    106      * @param {function} handler
     107     * @param {function(?)} handler
    107108     * @param {boolean=} disabled
    108109     * @return {WebInspector.ContextMenuItem}
    … …  
    145146    },
    146147
     148    /**
     149     * @param {!WebInspector.ContextMenuItem} item
     150     */
    147151    _pushItem: function(item)
    148152    {

  • trunk/Source/WebCore/inspector/front-end/ImageView.js

    r132659 r141574  
    133133    },
    134134
    135     _copyImageURL: function(event)
     135    _copyImageURL: function()
    136136    {
    137137        InspectorFrontendHost.copyText(this.resource.url);
    138138    },
    139139
    140     _openInNewTab: function(event)
     140    _openInNewTab: function()
    141141    {
    142142        InspectorFrontendHost.openInNewTab(this.resource.url);

  • trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

    r141417 r141574  
    10901090    },
    10911091
    1092     _clearBrowserCache: function(event)
     1092    _clearBrowserCache: function()
    10931093    {
    10941094        if (confirm(WebInspector.UIString("Are you sure you want to clear browser cache?")))
    … …  
    10961096    },
    10971097
    1098     _clearBrowserCookies: function(event)
     1098    _clearBrowserCookies: function()
    10991099    {
    11001100        if (confirm(WebInspector.UIString("Are you sure you want to clear browser cookies?")))

  • trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js

    r134031 r141574  
    16121612    },
    16131613
    1614     _refreshIndexedDB: function(event)
     1614    _refreshIndexedDB: function()
    16151615    {
    16161616        this._model.refreshDatabaseNames();

  • trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js

    r139454 r141574  
    217217    /**
    218218     * @param {WebInspector.UISourceCode} uiSourceCode
    219      * @param {Event} event
    220      */
    221     _handleEvaluateSnippet: function(uiSourceCode, event)
     219     */
     220    _handleEvaluateSnippet: function(uiSourceCode)
    222221    {
    223222        if (!uiSourceCode.isSnippet)
    … …  
    228227    /**
    229228     * @param {WebInspector.UISourceCode} uiSourceCode
    230      * @param {Event} event
    231      */
    232     _handleRenameSnippet: function(uiSourceCode, event)
     229     */
     230    _handleRenameSnippet: function(uiSourceCode)
    233231    {
    234232        this.dispatchEventToListeners(WebInspector.ScriptsNavigator.Events.ItemRenamingRequested, uiSourceCode);
    … …  
    237235    /**
    238236     * @param {WebInspector.UISourceCode} uiSourceCode
    239      * @param {Event} event
    240      */
    241     _handleRemoveSnippet: function(uiSourceCode, event)
     237     */
     238    _handleRemoveSnippet: function(uiSourceCode)
    242239    {
    243240        if (!uiSourceCode.isSnippet)
    … …  
    246243    },
    247244
    248     /**
    249      * @param {Event} event
    250      */
    251     _handleCreateSnippet: function(event)
     245    _handleCreateSnippet: function()
    252246    {
    253247        this._snippetCreationRequested();

  • trunk/Source/WebCore/inspector/front-end/Toolbar.js

    r140543 r141574  
    102102    _isDockedToBottom: function()
    103103    {
    104         return WebInspector.dockController && WebInspector.dockController.isDockedToBottom();
     104        return !!WebInspector.dockController && WebInspector.dockController.isDockedToBottom();
    105105    },
    106106
Note: See TracChangeset for help on using the changeset viewer.