Changeset 141590 in webkit


Ignore:
Timestamp:
Feb 1, 2013 7:27:15 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

PatchLog process durations are increasing linearly with time (faulty data logging)
​https://bugs.webkit.org/show_bug.cgi?id=108621

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.

Added a check to prevent a stop event from happening to the same patch multiple times.

  • QueueStatusServer/loggers/recordpatchevent.py:

(RecordPatchEvent.stopped):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r141585 r141590  
     12013-02-01  Alan Cutter  <alancutter@chromium.org>
     2
     3        PatchLog process durations are increasing linearly with time (faulty data logging)
     4        https://bugs.webkit.org/show_bug.cgi?id=108621
     5
     6        Reviewed by Eric Seidel.
     7
     8        Added a check to prevent a stop event from happening to the same patch multiple times.
     9
     10        * QueueStatusServer/loggers/recordpatchevent.py:
     11        (RecordPatchEvent.stopped):
     12
    1132013-02-01  Manuel Rego Casasnovas  <rego@igalia.com>
    214

  • trunk/Tools/QueueStatusServer/app.yaml

    r141451 r141590  
    11application: webkit-commit-queue
    2 version: 108427 # Bugzilla bug ID of last major change
     2version: 108621 # Bugzilla bug ID of last major change
    33runtime: python
    44api_version: 1

  • trunk/Tools/QueueStatusServer/loggers/recordpatchevent.py

    r141451 r141590  
    8686            return
    8787
    88         if bot_id:
    89             patch_log.bot_id = bot_id
    90         patch_log.finished = True
    91         patch_log.calculate_process_duration()
    92         patch_log.put()
     88        if not patch_log.finished:
     89            if bot_id:
     90                patch_log.bot_id = bot_id
     91            patch_log.finished = True
     92            patch_log.calculate_process_duration()
     93            patch_log.put()
    9394
    94         queue_log = QueueLog.get_current(queue_name, queue_log_duration)
    95         queue_log.patch_process_durations.append(patch_log.process_duration)
    96         queue_log.put()
     95            queue_log = QueueLog.get_current(queue_name, queue_log_duration)
     96            queue_log.patch_process_durations.append(patch_log.process_duration)
     97            queue_log.put()
    9798
    9899    @classmethod
Note: See TracChangeset for help on using the changeset viewer.