Changeset 141622 in webkit


Ignore:
Timestamp:
Feb 1, 2013 12:06:55 PM (11 years ago)
Author:
zandobersek@gmail.com
Message:

[GTK] Add WTFURL source files to the build
​https://bugs.webkit.org/show_bug.cgi?id=108215

Reviewed by Benjamin Poulain.

.:

  • Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.

This is required when using the WTFURL backend but otherwise doesn't affect the build.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.

Source/WTF:

The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.

  • GNUmakefile.am: List the directories from which source headers will be included.

Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.

  • GNUmakefile.list.am: Add build targets for the WTFURL source files.
  • wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and

reorder the inclusions.

  • wtf/url/src/URLCanon.h: Ditto.
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r141578 r141622  
     12013-02-01  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [GTK] Add WTFURL source files to the build
     4        https://bugs.webkit.org/show_bug.cgi?id=108215
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        * Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.
     9        This is required when using the WTFURL backend but otherwise doesn't affect the build.
     10
    1112013-02-01  Alexis Menard  <alexis@webkit.org>
    212

  • trunk/Source/WTF/ChangeLog

    r141591 r141622  
     12013-02-01  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [GTK] Add WTFURL source files to the build
     4        https://bugs.webkit.org/show_bug.cgi?id=108215
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
     9        meaning that the GTK port still uses the default KURL backend. To use the WTFURL
     10        backend instead, one would have to define WTF_USE_WTFURL in Platform.h.
     11
     12        * GNUmakefile.am: List the directories from which source headers will be included.
     13        Plenty of WTFURL code currently just includes the required header by name rather
     14        than specifying the header path as relative to Source/WTF. In the future all the inclusions
     15        should probaby be changed to include the header through the path relative to Source/WTF.
     16        * GNUmakefile.list.am: Add build targets for the WTFURL source files.
     17        * wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and
     18        reorder the inclusions.
     19        * wtf/url/src/URLCanon.h: Ditto.
     20
    1212013-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
    222

  • trunk/Source/WTF/GNUmakefile.am

    r120956 r141622  
    3636        -I$(srcdir)/Source \
    3737        -I$(srcdir)/Source/WTF \
    38         -I$(srcdir)/Source/WTF/wtf
     38        -I$(srcdir)/Source/WTF/wtf \
     39        -I$(srcdir)/Source/WTF/wtf/url/api \
     40        -I$(srcdir)/Source/WTF/wtf/url/src

  • trunk/Source/WTF/GNUmakefile.list.am

    r139974 r141622  
    264264    Source/WTF/wtf/unicode/icu/CollatorICU.cpp \
    265265    Source/WTF/wtf/unicode/icu/UnicodeIcu.h \
     266    Source/WTF/wtf/url/api/ParsedURL.cpp \
     267    Source/WTF/wtf/url/api/ParsedURL.h \
    266268    Source/WTF/wtf/url/api/URLBuffer.h \
    267269    Source/WTF/wtf/url/api/URLQueryCharsetConverter.h \
     270    Source/WTF/wtf/url/api/URLString.cpp \
     271    Source/WTF/wtf/url/api/URLString.h \
     272    Source/WTF/wtf/url/src/RawURLBuffer.h \
     273    Source/WTF/wtf/url/src/URLCanonEtc.cpp \
     274    Source/WTF/wtf/url/src/URLCanonFilesystemurl.cpp \
     275    Source/WTF/wtf/url/src/URLCanonFileurl.cpp \
     276    Source/WTF/wtf/url/src/URLCanonHost.cpp \
     277    Source/WTF/wtf/url/src/URLCanonICU.cpp \
     278    Source/WTF/wtf/url/src/URLCanonInternal.cpp \
     279    Source/WTF/wtf/url/src/URLCanonInternal.h \
     280    Source/WTF/wtf/url/src/URLCanonIP.cpp \
     281    Source/WTF/wtf/url/src/URLCanonMailto.cpp \
     282    Source/WTF/wtf/url/src/URLCanonPath.cpp \
     283    Source/WTF/wtf/url/src/URLCanonPathurl.cpp \
     284    Source/WTF/wtf/url/src/URLCanonQuery.cpp \
     285    Source/WTF/wtf/url/src/URLCanonRelative.cpp \
     286    Source/WTF/wtf/url/src/URLCanonStdURL.cpp \
     287    Source/WTF/wtf/url/src/URLCanon.h \
     288    Source/WTF/wtf/url/src/URLCharacterTypes.cpp \
     289    Source/WTF/wtf/url/src/URLCharacterTypes.h \
     290    Source/WTF/wtf/url/src/URLComponent.h \
     291    Source/WTF/wtf/url/src/URLFile.h \
     292    Source/WTF/wtf/url/src/URLParse.cpp \
     293    Source/WTF/wtf/url/src/URLParseFile.cpp \
     294    Source/WTF/wtf/url/src/URLParseInternal.h \
     295    Source/WTF/wtf/url/src/URLParse.h \
     296    Source/WTF/wtf/url/src/URLSegments.cpp \
     297    Source/WTF/wtf/url/src/URLSegments.h \
     298    Source/WTF/wtf/url/src/URLUtil.cpp \
     299    Source/WTF/wtf/url/src/URLUtil.h \
     300    Source/WTF/wtf/url/src/URLUtilInternal.h \
    268301    Source/WTF/wtf/win/OwnPtrWin.cpp

  • trunk/Source/WTF/wtf/url/api/ParsedURL.cpp

    r132261 r141622  
    3131
    3232#include <wtf/DataLog.h>
    33 #include <wtf/RawURLBuffer.h>
    34 #include <wtf/URLComponent.h>
    35 #include <wtf/URLUtil.h>
    3633#include <wtf/text/CString.h>
    3734#include <wtf/text/StringImpl.h>
     35#include <wtf/url/src/RawURLBuffer.h>
     36#include <wtf/url/src/URLComponent.h>
     37#include <wtf/url/src/URLUtil.h>
    3838
    3939namespace WTF {

  • trunk/Source/WTF/wtf/url/src/URLCanon.h

    r129413 r141622  
    3232#define URLCanon_h
    3333
    34 #include "URLBuffer.h"
    35 #include "URLParse.h"
    3634#include <stdlib.h>
    3735#include <wtf/unicode/Unicode.h>
     36#include <wtf/url/api/URLBuffer.h>
     37#include <wtf/url/src/URLParse.h>
    3838
    3939#if USE(WTFURL)

  • trunk/Source/WebCore/ChangeLog

    r141621 r141622  
     12013-02-01  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [GTK] Add WTFURL source files to the build
     4        https://bugs.webkit.org/show_bug.cgi?id=108215
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        * platform/KURLWTFURL.cpp:
     9        (WebCore): Only use the stub implementation of the fileSystemPath method for the
     10        Apple ports, other ports should for now still rely on their platform-specific implementations.
     11
    1122013-02-01  Mike West  <mkwst@chromium.org>
    213

  • trunk/Source/WebCore/platform/KURLWTFURL.cpp

    r135469 r141622  
    282282
    283283// FIXME: Get rid of this function from KURL.
     284#if PLATFORM(MAC) || PLATFORM(WIN)
    284285String KURL::fileSystemPath() const
    285286{
    286287    return string();
    287288}
     289#endif
    288290
    289291bool KURL::protocolIs(const char* testProtocol) const

  • trunk/Source/autotools/symbols.filter

    r141229 r141622  
    244244_ZN7WebCore28InspectorFrontendClientLocal11isUnderTestEv;
    245245_ZN7WebCore7Element16createShadowRootERi;
     246_ZNK7WebCore4KURL6stringEv;
    246247
    247248local:
Note: See TracChangeset for help on using the changeset viewer.