Changeset 141650 in webkit

Timestamp:

Feb 1, 2013 3:03:57 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
​https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

• src/ContextMenuClientImpl.cpp:

(WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
(WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
​https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

• platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/TestExpectations (modified) (1 diff)
• Source/WebKit/chromium/ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
+
+        [Chromium] Expect spellcheck to ignore punctuation
+        https://bugs.webkit.org/show_bug.cgi?id=108511
+
+        Reviewed by Tony Chang.
+
+        * platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.
+
 2013-02-01  Andrey Lushnikov  <lushnikov@chromium.org>
 

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -4346 +4346 @@
 webkit.org/b/108286 platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down.html [ ImageOnlyFailure ]
 
-# Spellchecker behavior tests.
-webkit.org/b/108370 editing/spelling/spelling-double-clicked-word-with-underscores.html [ Failure ]
-webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Failure ]
-webkit.org/b/108370 editing/spelling/spelling-with-underscore-selection.html [ Failure ]
-
 webkit.org/b/108424 media/video-error-does-not-exist.html [ Failure Crash ]
 webkit.org/b/108566 platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html [ Failure ]

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
+
+        [Chromium] Ignore punctuation in spellcheck
+        https://bugs.webkit.org/show_bug.cgi?id=108511
+
+        Reviewed by Tony Chang.
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
+        (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
+
 2013-02-01  Philip Rogers  <pdr@google.com>
 

trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

@@ -145 +145 @@
 }
 
+static bool IsWhiteSpaceOrPunctuation(UChar c)
+{
+    return isSpaceOrNewline(c) || WTF::Unicode::isPunct(c);
+}
+
 static String selectMisspellingAsync(Frame* selectedFrame, Vector<DocumentMarker*>& markers)
 {
@@ -167 +172 @@
     }
 
-    if (markerRange->text().stripWhiteSpace() != selectionRange->text().stripWhiteSpace())
+    if (markerRange->text().stripWhiteSpace(&IsWhiteSpaceOrPunctuation) != selectionRange->text().stripWhiteSpace(&IsWhiteSpaceOrPunctuation))
         return String();