Changeset 141662 in webkit

Timestamp:

Feb 1, 2013 4:26:25 PM (11 years ago)

Author:

fpizlo@apple.com

Message:

Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
​https://bugs.webkit.org/show_bug.cgi?id=108717

Reviewed by Mark Hahnenberg.

I think this makes the code clearer. It doesn't change behavior.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGByteCodeParser.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-02-01  Filip Pizlo  <fpizlo@apple.com>
+
+        Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
+        https://bugs.webkit.org/show_bug.cgi?id=108717
+
+        Reviewed by Mark Hahnenberg.
+        
+        I think this makes the code clearer. It doesn't change behavior.
+
+        * dfg/DFGByteCodeParser.cpp:
+        (JSC::DFG::ByteCodeParser::parse):
+
 2013-02-01  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

@@ -3731 +3731 @@
 #endif
     
-    m_currentProfilingIndex = m_currentIndex;
-    
-    processPhiStack<LocalPhiStack>();
-#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
-    dataLogF("Processing argument phis.\n");
-#endif
-    processPhiStack<ArgumentPhiStack>();
-
     for (BlockIndex blockIndex = 0; blockIndex < m_graph.m_blocks.size(); ++blockIndex) {
         BasicBlock* block = m_graph.m_blocks[blockIndex].get();
@@ -3746 +3738 @@
     }
     
+    m_currentProfilingIndex = m_currentIndex;
+    
+    processPhiStack<LocalPhiStack>();
+#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
+    dataLogF("Processing argument phis.\n");
+#endif
+    processPhiStack<ArgumentPhiStack>();
+
     fixVariableAccessPredictions();