Changeset 141674 in webkit

Timestamp:

Feb 1, 2013 6:35:57 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r141662.
​http://trac.webkit.org/changeset/141662
​https://bugs.webkit.org/show_bug.cgi?id=108738

it's an incorrect change since processPhiStack will
dereference dangling BasicBlock pointers (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-01

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGByteCodeParser.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r141662.
+        http://trac.webkit.org/changeset/141662
+        https://bugs.webkit.org/show_bug.cgi?id=108738
+
+        it's an incorrect change since processPhiStack will
+        dereference dangling BasicBlock pointers (Requested by pizlo
+        on #webkit).
+
+        * dfg/DFGByteCodeParser.cpp:
+        (JSC::DFG::ByteCodeParser::parse):
+
 2013-02-01  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

@@ -3731 +3731 @@
 #endif
     
+    m_currentProfilingIndex = m_currentIndex;
+    
+    processPhiStack<LocalPhiStack>();
+#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
+    dataLogF("Processing argument phis.\n");
+#endif
+    processPhiStack<ArgumentPhiStack>();
+
     for (BlockIndex blockIndex = 0; blockIndex < m_graph.m_blocks.size(); ++blockIndex) {
         BasicBlock* block = m_graph.m_blocks[blockIndex].get();
@@ -3738 +3746 @@
     }
     
-    m_currentProfilingIndex = m_currentIndex;
-    
-    processPhiStack<LocalPhiStack>();
-#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
-    dataLogF("Processing argument phis.\n");
-#endif
-    processPhiStack<ArgumentPhiStack>();
-
     fixVariableAccessPredictions();