Changeset 141692 in webkit
- Timestamp:
- Feb 2, 2013 5:55:00 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r141691 r141692 1 2013-02-02 Antoine Quint <graouts@apple.com> 2 3 Creating a WebInspector.ContextMenu without an event crashes WebCore when calling .show() 4 https://bugs.webkit.org/show_bug.cgi?id=108636 5 6 Reviewed by Pavel Feldman. 7 8 Return early if InspectorFrontendHost::showContextMenu() is called without an event and 9 assert in ContextMenuController::createContextMenu() in case no event was provided. 10 11 * inspector/InspectorFrontendHost.cpp: 12 (WebCore::InspectorFrontendHost::showContextMenu): 13 * page/ContextMenuController.cpp: 14 (WebCore::ContextMenuController::createContextMenu): 15 1 16 2013-02-02 Jonathan Feldstein <jfeldstein@rim.com> 2 17 -
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
r140539 r141692 270 270 void InspectorFrontendHost::showContextMenu(Event* event, const Vector<ContextMenuItem>& items) 271 271 { 272 if (!event) 273 return; 274 272 275 ASSERT(m_frontendPage); 273 276 ScriptState* frontendScriptState = scriptStateFromPage(debuggerWorld(), m_frontendPage); -
trunk/Source/WebCore/page/ContextMenuController.cpp
r139412 r141692 143 143 PassOwnPtr<ContextMenu> ContextMenuController::createContextMenu(Event* event) 144 144 { 145 ASSERT(event); 146 145 147 if (!event->isMouseEvent()) 146 148 return nullptr;
Note: See TracChangeset
for help on using the changeset viewer.