Changeset 141833 in webkit

Timestamp:

Feb 4, 2013 4:54:34 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
​https://bugs.webkit.org/show_bug.cgi?id=107639

Patch by Seulgi Kim <​seulgikim@company100.net> on 2013-02-04
Reviewed by Kenneth Rohde Christiansen.

In TiledBackingStore::adjustForContentsRect method, inflating is not
needed when there is no intersections between the cover/keep rect and
the content rect.

No new tests, no change in functionality.

• platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::adjustForContentsRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/TiledBackingStore.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-04  Seulgi Kim  <seulgikim@company100.net>
+
+        Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
+        https://bugs.webkit.org/show_bug.cgi?id=107639
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        In TiledBackingStore::adjustForContentsRect method, inflating is not
+        needed when there is no intersections between the cover/keep rect and
+        the content rect.
+
+        No new tests, no change in functionality.
+
+        * platform/graphics/TiledBackingStore.cpp:
+        (WebCore::TiledBackingStore::adjustForContentsRect):
+
 2013-02-04  Stephen White  <senorblanco@chromium.org>
 

trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

@@ -363 +363 @@
         return;
 
+    /*
+     * In the following case, there is no intersection of the contents rect and the cover/keep rect.
+     * Thus the latter should not be inflated.
+     *
+     *  +---------------+
+     *  |   m_rect      |
+     *  +---------------+
+     *
+     *          +-------------------------------+
+     *          |      cover or keep rect       |
+     *          |         +---------+           |
+     *          |         | visible |           |
+     *          |         |  rect   |           |
+     *          |         +---------+           |
+     *          +-------------------------------+
+     */
+    if (rect.isEmpty())
+        return;
+
     // Even now we might cover more than the content area so let's inflate in the
     // opposite directions.