Changeset 141904 in webkit


Ignore:
Timestamp:
Feb 5, 2013 10:55:57 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.

Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.

Location:
trunk/Source/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r141900 r141904  
     12013-02-05  Sami Kyostila  <skyostil@chromium.org>
     2
     3        [chromium] Make overlay layers slow-scrolling
     4        https://bugs.webkit.org/show_bug.cgi?id=108957
     5
     6        Reviewed by James Robinson.
     7
     8        Since overlay layers get inserted on top of everything else, we must
     9        mark them slow-scrolling to prevent all scroll input events to the rest
     10        of the page from getting blocked. This is also more correct because
     11        generally the overlay contents need to be repainted whenever the scroll
     12        offset changes, and with this patch the painting happens in sync with
     13        page scrolling.
     14
    1152013-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
    216
  • trunk/Source/WebKit/chromium/src/PageOverlay.cpp

    r139829 r141904  
    3131
    3232#include "GraphicsLayer.h"
     33#include "GraphicsLayerChromium.h"
    3334#include "GraphicsLayerClient.h"
    3435#include "Page.h"
     
    3839#include "WebViewClient.h"
    3940#include "WebViewImpl.h"
     41#include <public/WebLayer.h>
    4042
    4143using namespace WebCore;
     
    142144    m_viewImpl->setOverlayLayer(m_layer.get());
    143145    m_layer->setNeedsDisplay();
     146
     147    WebLayer* platformLayer = static_cast<GraphicsLayerChromium*>(m_layer.get())->platformLayer();
     148    platformLayer->setShouldScrollOnMainThread(true);
    144149#endif
    145150}
Note: See TracChangeset for help on using the changeset viewer.