Changeset 142029 in webkit

Timestamp:

Feb 6, 2013 1:49:48 PM (11 years ago)

Author:

tonyg@chromium.org

Message:

Fix CompactHTMLToken's copy ctor to copy all fields
​https://bugs.webkit.org/show_bug.cgi?id=109076

Reviewed by Adam Barth.

This was introduced by me in r142004. Without this patch we fail all tests when using the background parser.

Also don't use getters in copy ctor.

No new tests because no new functionality.

• html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/CompactHTMLToken.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-06  Tony Gentilcore  <tonyg@chromium.org>
+
+        Fix CompactHTMLToken's copy ctor to copy all fields
+        https://bugs.webkit.org/show_bug.cgi?id=109076
+
+        Reviewed by Adam Barth.
+
+        This was introduced by me in r142004. Without this patch we fail all tests when using the background parser.
+
+        Also don't use getters in copy ctor.
+
+        No new tests because no new functionality.
+
+        * html/parser/CompactHTMLToken.cpp:
+        (WebCore::CompactHTMLToken::CompactHTMLToken):
+
 2013-02-06  Brian Salomon  <bsalomon@google.com>
 

trunk/Source/WebCore/html/parser/CompactHTMLToken.cpp

@@ -90 +90 @@
 
 CompactHTMLToken::CompactHTMLToken(const CompactHTMLToken& other)
-    : m_type(other.type())
-    , m_isAll8BitData(other.isAll8BitData())
-    , m_doctypeForcesQuirks(other.doctypeForcesQuirks())
-    , m_textPosition(other.textPosition())
+    : m_type(other.m_type)
+    , m_selfClosing(other.m_selfClosing)
+    , m_isAll8BitData(other.m_isAll8BitData)
+    , m_doctypeForcesQuirks(other.m_doctypeForcesQuirks)
+    , m_data(other.m_data)
+    , m_attributes(other.m_attributes)
+    , m_textPosition(other.m_textPosition)
 {
-    if (other.xssInfo())
-        m_xssInfo = adoptPtr(new XSSInfo(*other.xssInfo()));
+    if (other.m_xssInfo)
+        m_xssInfo = adoptPtr(new XSSInfo(*other.m_xssInfo));
 }