Changeset 142107 in webkit


Ignore:
Timestamp:
Feb 7, 2013 5:56:05 AM (11 years ago)
Author:
vsevik@chromium.org
Message:

Web Inspector: Closure compilation fixes
​https://bugs.webkit.org/show_bug.cgi?id=109131

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):

  • inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):

  • inspector/front-end/SidebarPane.js:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r142103 r142107  
     12013-02-07  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Closure compilation fixes
     4        https://bugs.webkit.org/show_bug.cgi?id=109131
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/front-end/ElementsPanel.js:
     9        (WebInspector.ElementsPanel):
     10        * inspector/front-end/FileSystemMapping.js:
     11        (WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):
     12        * inspector/front-end/IsolatedFileSystemModel.js:
     13        (WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):
     14        * inspector/front-end/SidebarPane.js:
     15
    1162013-02-07  Kentaro Hara  <haraken@chromium.org>
    217

  • trunk/Source/WebCore/inspector/front-end/ElementsPanel.js

    r141777 r142107  
    8787    this.sidebarPanes.eventListeners = new WebInspector.EventListenersSidebarPane();
    8888
    89     this.sidebarPanes.styles.setShowCallback(this.updateStyles.bind(this));
     89    this.sidebarPanes.styles.setShowCallback(this.updateStyles.bind(this, false));
    9090    this.sidebarPanes.metrics.setShowCallback(this.updateMetrics.bind(this));
    9191    this.sidebarPanes.properties.setShowCallback(this.updateProperties.bind(this));

  • trunk/Source/WebCore/inspector/front-end/FileSystemMapping.js

    r141888 r142107  
    5050     * @param {string} fileSystemPath
    5151     * @param {string} filePath
    52      * @return {string}
     52     * @return {?string}
    5353     */
    5454    uriForFile: function(fileSystemPath, filePath) { },
    … …  
    121121    /**
    122122     * @param {string} fileSystemPath
    123      * @return {?string}
     123     * @return {string}
    124124     */
    125125    addFileSystemMapping: function(fileSystemPath)
    … …  
    199199        if (this._cachedURIPrefixes.hasOwnProperty(pathPrefix))
    200200            return this._cachedURIPrefixes[pathPrefix];
    201         var uriPrefix;
     201        var uriPrefix = null;
    202202        for (var id in this._fileSystemPaths) {
    203203            var fileSystemPath = this._fileSystemPaths[id];

  • trunk/Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js

    r141888 r142107  
    157157    {
    158158        var fileSystemId = this._fileSystemMapping.fileSystemId(fileSystemPath);
    159         this._workspace.removeProject(fileSystemId);
     159        if (fileSystemId)
     160            this._workspace.removeProject(fileSystemId);
    160161        this._fileSystemMapping.removeFileSystemMapping(fileSystemPath);
    161162        delete this._fileSystems[fileSystemPath];

  • trunk/Source/WebCore/inspector/front-end/SidebarPane.js

    r141777 r142107  
    5252
    5353    /**
    54      * @param {function} callback
     54     * @param {function()} callback
    5555     */
    5656    prepareContent: function(callback)
    … …  
    7373
    7474    /**
    75      * @param {function} callback
     75     * @param {function()} callback
    7676     * @return {boolean}
    7777     */
    … …  
    8585
    8686    /**
    87      * @param {function} callback
     87     * @param {function()} callback
    8888     */
    8989    setShowCallback: function(callback)
Note: See TracChangeset for help on using the changeset viewer.