Changeset 14211 in webkit

Timestamp:

May 5, 2006 1:35:57 PM (18 years ago)

Author:

ap

Message:

Reviewed by Maciej.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8626 Strict mode erroneously triggered by a broken comment

Test: fast/parser/broken-comments-vs-parsing-mode.html

• page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Call determineParseMode() if needed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/broken-comments-vs-parsing-mode-expected.checksum (added)
• LayoutTests/fast/parser/broken-comments-vs-parsing-mode-expected.png (added)
• LayoutTests/fast/parser/broken-comments-vs-parsing-mode-expected.txt (added)
• LayoutTests/fast/parser/broken-comments-vs-parsing-mode.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Frame.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2006-05-05  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Maciej.
+
+        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8626
+          Strict mode erroneously triggered by a broken comment
+
+        * fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Added.
+        * fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
+        * fast/parser/broken-comments-vs-parsing-mode-expected.txt: Added.
+        * fast/parser/broken-comments-vs-parsing-mode.html: Added.
+
 2006-05-05  Darin Adler  <darin@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-05-05  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Maciej.
+
+        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8626
+          Strict mode erroneously triggered by a broken comment
+
+        Test: fast/parser/broken-comments-vs-parsing-mode.html
+
+        * page/Frame.cpp:
+        (WebCore::Frame::endIfNotLoading): Call determineParseMode() if needed.
+
 2006-05-05  Darin Adler  <darin@apple.com>
 

trunk/WebCore/page/Frame.cpp

@@ -684 +684 @@
     // make sure nothing's left in there...
     if (d->m_doc) {
-        if (d->m_decoder)
-            write(d->m_decoder->flush());
+        if (d->m_decoder) {
+            DeprecatedString decoded = d->m_decoder->flush();
+            if (d->m_bFirstData) {
+                d->m_doc->determineParseMode(decoded);
+                d->m_bFirstData = false;
+            }
+            write(decoded);
+        }
         d->m_doc->finishParsing();
     } else