Changeset 142136 in webkit

Timestamp:

Feb 7, 2013 8:46:49 AM (11 years ago)

Author:

mikhail.pozdnyakov@intel.com

Message:

[WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
​https://bugs.webkit.org/show_bug.cgi?id=109185

Reviewed by Kenneth Rohde Christiansen.

This patch is disabling paints clipping logic added at r142045 for the case
when the view should render the entire contents (case of using tiled backing store).

No new tests, covered by plenty of existing manual tests that allow scrolling
(for example fixed-position.html).

• platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-07  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
+        https://bugs.webkit.org/show_bug.cgi?id=109185
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        This patch is disabling paints clipping logic added at r142045 for the case 
+        when the view should render the entire contents (case of using tiled backing store).
+
+        No new tests, covered by plenty of existing manual tests that allow scrolling
+        (for example fixed-position.html).
+
+        * platform/ScrollView.cpp:
+        (WebCore::ScrollView::paint):
+
 2013-02-07  Vladislav Kaznacheev  <kaznacheev@chromium.org>
 

trunk/Source/WebCore/platform/ScrollView.cpp

@@ -1053 +1053 @@
 
     IntRect documentDirtyRect = rect;
-    IntRect visibleAreaWithoutScrollbars(location(), visibleContentRect(false).size());
-    documentDirtyRect.intersect(visibleAreaWithoutScrollbars);
+    if (!paintsEntireContents()) {
+        IntRect visibleAreaWithoutScrollbars(location(), visibleContentRect(false).size());
+        documentDirtyRect.intersect(visibleAreaWithoutScrollbars);
+    }
 
     if (!documentDirtyRect.isEmpty()) {