Changeset 142209 in webkit
- Timestamp:
- Feb 7, 2013 5:06:30 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r142206 r142209 1 2013-02-07 Kentaro Hara <haraken@chromium.org> 2 3 [V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype() 4 https://bugs.webkit.org/show_bug.cgi?id=109167 5 6 Reviewed by Andreas Kling. 7 8 Given that assertContextHasCorrectPrototype() is anyway empty in a release 9 build, we don't need to surround it with #ifndef NDEBUG. 10 11 No tests. No change in behavior. 12 13 * bindings/v8/DOMWrapperWorld.cpp: 14 (WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype): 15 * bindings/v8/DOMWrapperWorld.h: 16 (DOMWrapperWorld): 17 (WebCore::DOMWrapperWorld::isolated): 18 1 19 2013-02-07 Alexei Svitkine <asvitkine@chromium.org> 2 20 -
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp
r141771 r142209 68 68 } 69 69 70 #ifndef NDEBUG71 70 void DOMWrapperWorld::assertContextHasCorrectPrototype(v8::Handle<v8::Context> context) 72 71 { … … 74 73 ASSERT(V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8DOMWindow::info)); 75 74 } 76 #endif77 75 78 76 static void isolatedWorldWeakCallback(v8::Isolate* isolate, v8::Persistent<v8::Value> object, void* parameter) -
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h
r142103 r142209 61 61 void makeContextWeak(v8::Handle<v8::Context>); 62 62 void setIsolatedWorldField(v8::Handle<v8::Context>); 63 #ifndef NDEBUG 63 64 64 static void assertContextHasCorrectPrototype(v8::Handle<v8::Context>); 65 #endif66 65 static DOMWrapperWorld* isolated(v8::Handle<v8::Context> context) 67 66 { 68 #ifndef NDEBUG69 67 assertContextHasCorrectPrototype(context); 70 #endif71 68 return static_cast<DOMWrapperWorld*>(context->GetAlignedPointerFromEmbedderData(v8ContextIsolatedWorld)); 72 69 }
Note: See TracChangeset
for help on using the changeset viewer.