Changeset 142209 in webkit


Ignore:
Timestamp:
Feb 7, 2013 5:06:30 PM (11 years ago)
Author:
haraken@chromium.org
Message:

[V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
https://bugs.webkit.org/show_bug.cgi?id=109167

Reviewed by Andreas Kling.

Given that assertContextHasCorrectPrototype() is anyway empty in a release
build, we don't need to surround it with #ifndef NDEBUG.

No tests. No change in behavior.

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r142206 r142209  
     12013-02-07  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
     4        https://bugs.webkit.org/show_bug.cgi?id=109167
     5
     6        Reviewed by Andreas Kling.
     7
     8        Given that assertContextHasCorrectPrototype() is anyway empty in a release
     9        build, we don't need to surround it with #ifndef NDEBUG.
     10
     11        No tests. No change in behavior.
     12
     13        * bindings/v8/DOMWrapperWorld.cpp:
     14        (WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype):
     15        * bindings/v8/DOMWrapperWorld.h:
     16        (DOMWrapperWorld):
     17        (WebCore::DOMWrapperWorld::isolated):
     18
    1192013-02-07  Alexei Svitkine  <asvitkine@chromium.org>
    220
  • trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp

    r141771 r142209  
    6868}
    6969
    70 #ifndef NDEBUG
    7170void DOMWrapperWorld::assertContextHasCorrectPrototype(v8::Handle<v8::Context> context)
    7271{
     
    7473    ASSERT(V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8DOMWindow::info));
    7574}
    76 #endif
    7775
    7876static void isolatedWorldWeakCallback(v8::Isolate* isolate, v8::Persistent<v8::Value> object, void* parameter)
  • trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h

    r142103 r142209  
    6161    void makeContextWeak(v8::Handle<v8::Context>);
    6262    void setIsolatedWorldField(v8::Handle<v8::Context>);
    63 #ifndef NDEBUG
     63
    6464    static void assertContextHasCorrectPrototype(v8::Handle<v8::Context>);
    65 #endif
    6665    static DOMWrapperWorld* isolated(v8::Handle<v8::Context> context)
    6766    {
    68 #ifndef NDEBUG
    6967        assertContextHasCorrectPrototype(context);
    70 #endif
    7168        return static_cast<DOMWrapperWorld*>(context->GetAlignedPointerFromEmbedderData(v8ContextIsolatedWorld));
    7269    }
Note: See TracChangeset for help on using the changeset viewer.