Changeset 142214 in webkit

Timestamp:

Feb 7, 2013 5:28:52 PM (11 years ago)

Author:

tkent@chromium.org

Message:

[Chromium-Android] Disable input[type=datetime]
​https://bugs.webkit.org/show_bug.cgi?id=107614

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

Reason:
​http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html

• features.gypi:

Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
We enable it for non-Android ports but the runtime flag for it is
disabled by default. The runtime flag is enabled only in DumpRenderTree.

LayoutTests:

• platform/chromium/TestExpectations:

Tetsts in fast/forms/datetime/ fail.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/TestExpectations (modified) (1 diff)
• Source/WebKit/chromium/ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/features.gypi (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-07  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium-Android] Disable input[type=datetime]
+        https://bugs.webkit.org/show_bug.cgi?id=107614
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations:
+        Tetsts in fast/forms/datetime/ fail.
+
 2013-02-07  Jeffrey Pfau  <jpfau@apple.com>
 

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -1842 +1842 @@
 webkit.org/b/98782 [ Android ] fast/css/getComputedStyle/computed-style-select-overflow.html [ Failure ]
 
+# [Chromium-Android] Disable <input type=datetime> implementation.
+crbug.com/164561 [ Android ] fast/forms/datetime/ [ Failure Pass ]
 # [Chromium-Android] No <input type=week> implementation.
 crbug.com/135938 [ Android ] fast/forms/week/ [ Failure Pass ]

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-07  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium-Android] Disable input[type=datetime]
+        https://bugs.webkit.org/show_bug.cgi?id=107614
+
+        Reviewed by Kentaro Hara.
+
+        Reason:
+        http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
+
+        * features.gypi:
+        Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
+        We enable it for non-Android ports but the runtime flag for it is
+        disabled by default. The runtime flag is enabled only in DumpRenderTree.
+
 2013-02-07  Terry Anderson  <tdanderson@chromium.org>
 

trunk/Source/WebKit/chromium/features.gypi

@@ -76 +76 @@
       'ENABLE_INDEXED_DATABASE=1',
       'ENABLE_INPUT_TYPE_DATE=1',
-      'ENABLE_INPUT_TYPE_DATETIME=1',
       'ENABLE_INPUT_TYPE_DATETIMELOCAL=1',
       'ENABLE_INPUT_TYPE_MONTH=1',
@@ -170 +169 @@
           'ENABLE_INPUT_SPEECH=0',
           'ENABLE_INPUT_TYPE_COLOR=0',
+          'ENABLE_INPUT_TYPE_DATETIME=0',
           'ENABLE_INPUT_TYPE_WEEK=0',
           'ENABLE_LEGACY_NOTIFICATIONS=0',
@@ -191 +191 @@
           'ENABLE_INPUT_SPEECH=1',
           'ENABLE_INPUT_TYPE_COLOR=1',
+          'ENABLE_INPUT_TYPE_DATETIME=1',
           'ENABLE_INPUT_TYPE_WEEK=1',
           'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1',