Changeset 142217 in webkit

Timestamp:

Feb 7, 2013 6:11:03 PM (11 years ago)

Author:

haraken@chromium.org

Message:

[V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
​https://bugs.webkit.org/show_bug.cgi?id=109186

Reviewed by Adam Barth.

V8HiddenPropertyName.h is a right place for setNamedHiddenReference().

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):

• bindings/v8/V8DOMWrapper.cpp:
• bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

• bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName):
(WebCore::V8HiddenPropertyName::setNamedHiddenReference):
(WebCore):

• bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):

• bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)
• bindings/scripts/test/V8/V8TestObj.cpp (modified) (1 diff)
• bindings/v8/V8DOMWrapper.cpp (modified) (1 diff)
• bindings/v8/V8DOMWrapper.h (modified) (1 diff)
• bindings/v8/V8HiddenPropertyName.cpp (modified) (2 diffs)
• bindings/v8/V8HiddenPropertyName.h (modified) (1 diff)
• bindings/v8/custom/V8MessageChannelCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-07  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
+        https://bugs.webkit.org/show_bug.cgi?id=109186
+
+        Reviewed by Adam Barth.
+
+        V8HiddenPropertyName.h is a right place for setNamedHiddenReference().
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateNormalAttrGetter):
+        * bindings/scripts/test/V8/V8TestObj.cpp:
+        (WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
+        * bindings/v8/V8DOMWrapper.cpp:
+        * bindings/v8/V8DOMWrapper.h:
+        (V8DOMWrapper):
+        * bindings/v8/V8HiddenPropertyName.cpp:
+        (WebCore::V8HiddenPropertyName::hiddenReferenceName):
+        (WebCore::V8HiddenPropertyName::setNamedHiddenReference):
+        (WebCore):
+        * bindings/v8/V8HiddenPropertyName.h:
+        (V8HiddenPropertyName):
+        (WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
+        * bindings/v8/custom/V8MessageChannelCustom.cpp:
+        (WebCore::V8MessageChannel::constructorCallbackCustom):
+        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+        (WebCore::toV8Object):
+
 2013-02-07  Elliott Sprehn  <esprehn@chromium.org>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -1050 +1050 @@
         push(@implContentDecls, "        wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());\n"); # FIXME: Could use wrap here since the wrapper is empty.
         push(@implContentDecls, "        if (!wrapper.IsEmpty())\n");
-        push(@implContentDecls, "            V8DOMWrapper::setNamedHiddenReference(info.Holder(), \"${attrName}\", wrapper);\n");
+        push(@implContentDecls, "            V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), \"${attrName}\", wrapper);\n");
         push(@implContentDecls, "    }\n");
         push(@implContentDecls, "    return wrapper;\n");

trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

@@ -124 +124 @@
         wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
         if (!wrapper.IsEmpty())
-            V8DOMWrapper::setNamedHiddenReference(info.Holder(), "readOnlyTestObjAttr", wrapper);
+            V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readOnlyTestObjAttr", wrapper);
     }
     return wrapper;

trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp

@@ -74 +74 @@
 };
 
-void V8DOMWrapper::setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child)
-{
-    ASSERT(name);
-    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);
-}
-
 v8::Local<v8::Object> V8DOMWrapper::createWrapper(v8::Handle<v8::Object> creationContext, WrapperTypeInfo* type, void* impl, v8::Isolate* isolate)
 {

trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h

@@ -63 +63 @@
         static bool isDOMWrapper(v8::Handle<v8::Value>);
         static bool isWrapperOfType(v8::Handle<v8::Value>, WrapperTypeInfo*);
-
-        // FIXME: Why is this function in V8DOMWrapper?
-        static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child);
     };
 

trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp

@@ -56 +56 @@
 V8_HIDDEN_PROPERTIES(V8_DEFINE_HIDDEN_PROPERTY);
 
-v8::Handle<v8::String> V8HiddenPropertyName::hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type)
+static v8::Handle<v8::String> hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type = NewSymbol)
 {
     ASSERT(length);
@@ -72 +72 @@
 }
 
+void V8HiddenPropertyName::setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child)
+{
+    ASSERT(name);
+    parent->SetHiddenValue(hiddenReferenceName(name, strlen(name)), child);
+}
+
 v8::Persistent<v8::String> V8HiddenPropertyName::createString(const char* key)
 {

trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h

@@ -49 +49 @@
     V(typedArrayHiddenCopyMethod)
 
-    enum V8HiddenPropertyCreationType { NewSymbol, NewString };
+enum V8HiddenPropertyCreationType { NewSymbol, NewString };
 
-    class V8HiddenPropertyName {
-    public:
-        V8HiddenPropertyName() { }
+class V8HiddenPropertyName {
+public:
+    V8HiddenPropertyName() { }
 #define V8_DECLARE_PROPERTY(name) static v8::Handle<v8::String> name();
-        V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY);
+    V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY);
 #undef V8_DECLARE_PROPERTY
 
-        static v8::Handle<v8::String> hiddenReferenceName(const char*, unsigned, V8HiddenPropertyCreationType = NewSymbol);
+    static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child);
 
-    private:
-        static v8::Persistent<v8::String> createString(const char* key);
+private:
+    static v8::Persistent<v8::String> createString(const char* key);
 #define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name;
-        V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
+    V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
 #undef V8_DECLARE_FIELD
-    };
+};
 
 }

trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp

@@ -55 +55 @@
     // MessagePort wrappers to make sure that the MessagePort wrappers
     // stay alive as long as the MessageChannel wrapper is around.
-    V8DOMWrapper::setNamedHiddenReference(wrapper, "port1", toV8(obj->port1(), args.Holder(), args.GetIsolate()));
-    V8DOMWrapper::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
+    V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port1", toV8(obj->port1(), args.Holder(), args.GetIsolate()));
+    V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
 
     V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);

trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

@@ -215 +215 @@
     }
     ASSERT(!extensionObject.IsEmpty());
-    V8DOMWrapper::setNamedHiddenReference(contextObject, referenceName, extensionObject);
+    V8HiddenPropertyName::setNamedHiddenReference(contextObject, referenceName, extensionObject);
     return extensionObject;
 }