Changeset 142219 in webkit

Timestamp:

Feb 7, 2013 6:41:21 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[Gtk] RunLoop::run shuold run current thread's run loop.
​https://bugs.webkit.org/show_bug.cgi?id=107887

Patch by Seulgi Kim <​seulgikim@company100.net> on 2013-02-07
Reviewed by Martin Robinson.

Currently, RunLoop in Gtk can use just main thread's event loop.
But the other ports are implemented to use RunLoop in sub threads.

This patch makes RunLoop constructor create new context, not use default
context.
But in the main thread still uses default context to use main event loop
since there is some codes using glib directly (e.g. in
LayerTreeHostGtk::scheduleLayerFlush).

No new tests. There is no case that uses RunLoop in off the main thread
yet.

• platform/gtk/RunLoopGtk.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::run):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RunLoopGtk.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-07  Seulgi Kim  <seulgikim@company100.net>
+
+        [Gtk] RunLoop::run shuold run current thread's run loop.
+        https://bugs.webkit.org/show_bug.cgi?id=107887
+
+        Reviewed by Martin Robinson.
+
+        Currently, RunLoop in Gtk can use just main thread's event loop.
+        But the other ports are implemented to use RunLoop in sub threads.
+
+        This patch makes RunLoop constructor create new context, not use default
+        context.
+        But in the main thread still uses default context to use main event loop
+        since there is some codes using glib directly (e.g. in
+        LayerTreeHostGtk::scheduleLayerFlush).
+
+        No new tests. There is no case that uses RunLoop in off the main thread
+        yet.
+
+        * platform/gtk/RunLoopGtk.cpp:
+        (WebCore::RunLoop::RunLoop):
+        (WebCore::RunLoop::run):
+
 2013-02-07  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/platform/gtk/RunLoopGtk.cpp

@@ -31 +31 @@
 #include <glib.h>
 
+#include <wtf/MainThread.h>
+
 namespace WebCore {
 
@@ -36 +38 @@
 {
     // g_main_context_default() doesn't add an extra reference.
-    m_runLoopContext = g_main_context_default();
+    m_runLoopContext = isMainThread() ? g_main_context_default() : adoptGRef(g_main_context_new());
     ASSERT(m_runLoopContext);
     GRefPtr<GMainLoop> innermostLoop = adoptGRef(g_main_loop_new(m_runLoopContext.get(), FALSE));
@@ -54 +56 @@
 void RunLoop::run()
 {
-    RunLoop* mainRunLoop = RunLoop::main();
+    RunLoop* mainRunLoop = RunLoop::current();
     GMainLoop* innermostLoop = mainRunLoop->innermostLoop();
     if (!g_main_loop_is_running(innermostLoop)) {