Changeset 142226 in webkit


Ignore:
Timestamp:
Feb 7, 2013 9:37:26 PM (11 years ago)
Author:
haraken@chromium.org
Message:

[V8] enum V8HiddenPropertyCreationType is not used
​https://bugs.webkit.org/show_bug.cgi?id=109250

Reviewed by Adam Barth.

V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.

No tests. No change in behavior.

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r142225 r142226  
     12013-02-07  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] enum V8HiddenPropertyCreationType is not used
     4        https://bugs.webkit.org/show_bug.cgi?id=109250
     5
     6        Reviewed by Adam Barth.
     7
     8        V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.
     9
     10        No tests. No change in behavior.
     11
     12        * bindings/v8/V8HiddenPropertyName.cpp:
     13        (WebCore::hiddenReferenceName):
     14        * bindings/v8/V8HiddenPropertyName.h:
     15        (WebCore):
     16
    1172013-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>
    218

  • trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp

    r142217 r142226  
    5656V8_HIDDEN_PROPERTIES(V8_DEFINE_HIDDEN_PROPERTY);
    5757
    58 static v8::Handle<v8::String> hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type = NewSymbol)
     58static v8::Handle<v8::String> hiddenReferenceName(const char* name, unsigned length)
    5959{
    6060    ASSERT(length);
    … …  
    6262    prefixedName.append(V8_HIDDEN_PROPERTY_PREFIX, sizeof(V8_HIDDEN_PROPERTY_PREFIX) - 1);
    6363    prefixedName.append(name, length);
    64     switch (type) {
    65     case NewSymbol:
    66         return v8::String::NewSymbol(prefixedName.data(), static_cast<int>(prefixedName.size()));
    67     case NewString:
    68         return v8::String::New(prefixedName.data(), static_cast<int>(prefixedName.size()));
    69     }
    70     ASSERT_NOT_REACHED();
    71     return v8::Handle<v8::String>();
     64    return v8::String::NewSymbol(prefixedName.data(), static_cast<int>(prefixedName.size()));
    7265}
    7366

  • trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h

    r142217 r142226  
    4949    V(typedArrayHiddenCopyMethod)
    5050
    51 enum V8HiddenPropertyCreationType { NewSymbol, NewString };
    52 
    5351class V8HiddenPropertyName {
    5452public:
Note: See TracChangeset for help on using the changeset viewer.