Changeset 142234 in webkit


Ignore:
Timestamp:
Feb 7, 2013 11:18:05 PM (11 years ago)
Author:
tkent@chromium.org
Message:

document.activeElement should not return a non-focusable element
https://bugs.webkit.org/show_bug.cgi?id=86707

Reviewed by Hajime Morita.

Source/WebCore:

This is based on a patch by Arpita Bahuguna.

Test: fast/dom/HTMLDocument/set-focus-on-valid-element.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):
Added check for verifying that the node to be focused is
focusable. However, this check should be skipped for HTMLPlugInElement
because it has special behavior.

LayoutTests:

  • fast/dom/HTMLDocument/set-focus-on-valid-element-expected.txt: Added.
  • fast/dom/HTMLDocument/set-focus-on-valid-element.html: Added.

This test verifies that document.activeElement does not return an
invalid or non-focusable element.

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r142229 r142234  
     12013-02-07  Kent Tamura  <tkent@chromium.org>
     2
     3        document.activeElement should not return a non-focusable element
     4        https://bugs.webkit.org/show_bug.cgi?id=86707
     5
     6        Reviewed by Hajime Morita.
     7
     8        * fast/dom/HTMLDocument/set-focus-on-valid-element-expected.txt: Added.
     9        * fast/dom/HTMLDocument/set-focus-on-valid-element.html: Added.
     10        This test verifies that document.activeElement does not return an
     11        invalid or non-focusable element.
     12
    1132013-02-07  Matt Falkenhagen  <falken@chromium.org>
    214
  • trunk/Source/WebCore/ChangeLog

    r142231 r142234  
     12013-02-07  Kent Tamura  <tkent@chromium.org>
     2
     3        document.activeElement should not return a non-focusable element
     4        https://bugs.webkit.org/show_bug.cgi?id=86707
     5
     6        Reviewed by Hajime Morita.
     7
     8        This is based on a patch by Arpita Bahuguna.
     9
     10        Test: fast/dom/HTMLDocument/set-focus-on-valid-element.html
     11
     12        * dom/Document.cpp:
     13        (WebCore::Document::setFocusedNode):
     14        Added check for verifying that the node to be focused is
     15        focusable. However, this check should be skipped for HTMLPlugInElement
     16        because it has special behavior.
     17
    1182013-02-07  Vladislav Kaznacheev  <kaznacheev@chromium.org>
    219
  • trunk/Source/WebCore/dom/Document.cpp

    r142223 r142234  
    33523352    }
    33533353
    3354     if (newFocusedNode) {
     3354    if (newFocusedNode && (newFocusedNode->isPluginElement() || newFocusedNode->isFocusable())) {
    33553355        if (newFocusedNode->isRootEditableElement() && !acceptsEditingFocus(newFocusedNode.get())) {
    33563356            // delegate blocks focus change
Note: See TracChangeset for help on using the changeset viewer.